Avoid treating "\\r\\n" as new line.#2569
Avoid treating "\\r\\n" as new line.#2569jnyrup merged 2 commits intofluentassertions:developfrom vbreuss:topic/remove-incorrect-verbatim-replacement
"\\r\\n" as new line.#2569Conversation
vbreuss
changed the title
@"\r\n" as new line."\\r\\n" as new line.
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Pull Request Test Coverage Report for Build 7664903396Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
|
I think the title is misleading. You're merely removing some code that doesn't do anything. |
Not really. The following test failed previously, but now no longer: [Fact]
public void Does_not_treat_escaped_newlines_as_newlines()
{
// Arrange
string actual = "te\r\nst";
string expect = "te\\r\\nst";
// Act / Assert
actual.Should().NotMatchEquivalentOf(expect);
}
Do you think it makes sense, to add this as a unit test? |
Ah, in that case, you're right and this is actually fixing a bug. Probably also needs a release notes entry then. |
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
4 participants
As mentioned in #2566 treating the verbatim string
@"\r\n"as a newline seems suspicius, as it is equivalent to"\\r\\n".IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome