Allow anonymous object for selecting fields/properties at `Exclude` and `Include` by IT-VBFK · Pull Request #2488 · fluentassertions/fluentassertions

IT-VBFK · 2023-11-27T16:35:12Z

This refers to Excluding() / .For().Exclude() and Including().

This closes #2479

IMPORTANT

If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
The code complies with the Coding Guidelines for C#.
The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
- Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

coveralls · 2023-11-27T16:44:47Z

Pull Request Test Coverage Report for Build 7036088817

24 of 24 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 97.485%

Totals
Change from base Build 7033738205:	0.01%
Covered Lines:	11756
Relevant Lines:	11940

💛 - Coveralls

github-actions · 2023-11-28T16:38:06Z

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register at Qodana Cloud and configure the action
Use GitHub Code Scanning with Qodana
Host Qodana report at GitHub Pages
Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

IT-VBFK · 2023-11-29T14:01:26Z

Hmm.. discovered a bad bug...

Will fix it in the evening 🫣

github-actions · 2024-10-31T21:38:04Z

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

coveralls · 2024-10-31T22:22:40Z

Pull Request Test Coverage Report for Build 11767671047

Details

32 of 32 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 97.771%

Totals
Change from base Build 11754697332:	0.01%
Covered Lines:	12357
Relevant Lines:	12516

💛 - Coveralls

Src/FluentAssertions/Common/ExpressionExtensions.cs

dennisdoomen

👍🏻 Very nice feature
🔧 We only use var if the type is obvious.

dennisdoomen · 2024-11-10T12:28:02Z

Src/FluentAssertions/Common/ExpressionExtensions.cs

-                    segments.Add($"[{argumentExpression.Value}]");
+                    singlePath = $"[{argumentExpression.Value}].{singlePath}";
+                    break;
+                case ExpressionType.New:


♻️ This entire method is become too bloated and needs some refactoring (but maybe not now). An implementation of the Strategy Pattern might be a better fit.

dennisdoomen · 2024-11-10T12:28:36Z

Src/FluentAssertions/Common/ExpressionExtensions.cs


-        IEnumerable<string> reversedSegments = segments.AsEnumerable().Reverse();
-        string segmentPath = string.Join(".", reversedSegments);
+        if (singlePath is null)


❓ What happens if singlePath is non-null and selectors isn't empty?

As I can see, this cannot happen, because you either have: .Excluding(p => p.NestedField)(which results in singlePath to be non-null and segments to be empty) or .Excluding(p => new { p.NestedField } ) (which results in singlePath null + segments not empty).

My point was that the code doesn't make that clear.

Should I add a comment for this?

Actually, we have do do it exactly like this, because in case of .Excluding(p => new { }) singlePath stays null and the segments stays empty.

In that case, I would make it an if, else if and else. Even though the huge switch is difficult to process, you at least can see what will happen at the end.

Src/FluentAssertions/Common/ExpressionExtensions.cs

Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Excluding.cs

docs/_pages/objectgraphs.md

docs/_pages/releases.md

IT-VBFK · 2024-11-10T13:12:10Z

I think I've addressed all the blocking changes.

This refers to `Excluding` / `For.Exclude` and `Including`

Co-authored-by: Dennis Doomen <[email protected]>

IT-VBFK changed the title ~~SAVEPOINT~~ Excluding properties with anonymous object Nov 27, 2023

IT-VBFK force-pushed the feat/excluding-with-anonymous-object branch 2 times, most recently from 552be02 to c1e2441 Compare November 28, 2023 16:28

IT-VBFK marked this pull request as ready for review November 28, 2023 16:29

IT-VBFK changed the title ~~Excluding properties with anonymous object~~ Excluding fields and properties with anonymous object Nov 28, 2023

IT-VBFK force-pushed the feat/excluding-with-anonymous-object branch 3 times, most recently from e869e49 to 1a87f18 Compare November 28, 2023 20:42

IT-VBFK changed the title ~~Excluding fields and properties with anonymous object~~ Allow anonymous object for selecting fields/properties at Exclude and Include Nov 28, 2023

IT-VBFK force-pushed the feat/excluding-with-anonymous-object branch from 1a87f18 to 1ac4b66 Compare November 28, 2023 21:19

IT-VBFK force-pushed the feat/excluding-with-anonymous-object branch from 1ac4b66 to 85cba3f Compare November 29, 2023 17:12

IT-VBFK marked this pull request as draft November 30, 2023 07:47

IT-VBFK mentioned this pull request Oct 31, 2024

[API Proposal]: Support for selecting multiple properties in single expression. #2479

Closed

IT-VBFK force-pushed the feat/excluding-with-anonymous-object branch 2 times, most recently from 8191b33 to b363b4b Compare October 31, 2024 22:19

IT-VBFK marked this pull request as ready for review November 2, 2024 08:06

IT-VBFK force-pushed the feat/excluding-with-anonymous-object branch from b363b4b to ba177ab Compare November 2, 2024 08:35

IT-VBFK commented Nov 2, 2024

View reviewed changes

Src/FluentAssertions/Common/ExpressionExtensions.cs Outdated Show resolved Hide resolved

IT-VBFK force-pushed the feat/excluding-with-anonymous-object branch 2 times, most recently from 6aa70b4 to fb28d7f Compare November 3, 2024 11:24

dennisdoomen requested changes Nov 10, 2024

View reviewed changes

IT-VBFK force-pushed the feat/excluding-with-anonymous-object branch 2 times, most recently from d3d766f to fe0e37c Compare November 10, 2024 13:11

IT-VBFK requested a review from dennisdoomen November 10, 2024 13:11

IT-VBFK and others added 3 commits November 10, 2024 19:51

Allow an anonymous object for selection

53733bf

This refers to `Excluding` / `For.Exclude` and `Including`

Add documentation

a1a2d68

Co-authored-by: Dennis Doomen <[email protected]>

Add release notes

b0c2ff7

Co-authored-by: Dennis Doomen <[email protected]>

IT-VBFK force-pushed the feat/excluding-with-anonymous-object branch from fe0e37c to b0c2ff7 Compare November 10, 2024 18:51

dennisdoomen approved these changes Nov 11, 2024

View reviewed changes

dennisdoomen merged commit f8700b2 into fluentassertions:develop Nov 11, 2024

IT-VBFK deleted the feat/excluding-with-anonymous-object branch November 11, 2024 23:16

Conversation

IT-VBFK commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

IMPORTANT

Uh oh!

coveralls commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 7036088817

💛 - Coveralls

Uh oh!

github-actions bot commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Qodana for .NET

Uh oh!

IT-VBFK commented Nov 29, 2023

Uh oh!

github-actions bot commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Qodana for .NET

Uh oh!

coveralls commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 11767671047

Details

💛 - Coveralls

Uh oh!

Uh oh!

dennisdoomen left a comment

Choose a reason for hiding this comment

Uh oh!

dennisdoomen Nov 10, 2024

Choose a reason for hiding this comment

Uh oh!

dennisdoomen Nov 10, 2024

Choose a reason for hiding this comment

Uh oh!

IT-VBFK Nov 10, 2024

Choose a reason for hiding this comment

Uh oh!

dennisdoomen Nov 10, 2024

Choose a reason for hiding this comment

Uh oh!

IT-VBFK Nov 10, 2024

Choose a reason for hiding this comment

Uh oh!

IT-VBFK Nov 10, 2024

Choose a reason for hiding this comment

Uh oh!

dennisdoomen Nov 11, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IT-VBFK commented Nov 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

IT-VBFK commented Nov 27, 2023 •

edited

Loading

coveralls commented Nov 27, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Oct 31, 2024 •

edited

Loading

coveralls commented Oct 31, 2024 •

edited

Loading