Skip to content

Use Qodana EAP to support .NET 8#2474

Merged
jnyrup merged 1 commit intofluentassertions:developfrom
vbreuss:topic/add-eap-argument
Nov 20, 2023
Merged

Use Qodana EAP to support .NET 8#2474
jnyrup merged 1 commit intofluentassertions:developfrom
vbreuss:topic/add-eap-argument

Conversation

@vbreuss
Copy link
Copy Markdown
Contributor

@vbreuss vbreuss commented Nov 19, 2023 •
edited
Loading

Add -EAP to argument for Qodana Scan as Qodana currently only supports .NET 8 in the EAP (Early-Access Program):
https://youtrack.jetbrains.com/issue/QD-7660/Qodana-busted-in-.NET-8-RTM

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@vbreuss vbreuss marked this pull request as ready for review November 19, 2023 20:51
@vbreuss vbreuss mentioned this pull request Nov 19, 2023
Merged
7 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 19, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 19, 2023

Pull Request Test Coverage Report for Build 6922866212

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.475%
Totals Coverage Status
Change from base Build 6921526791: 0.0%
Covered Lines: 11742
Relevant Lines: 11926
💛 - Coveralls

@vbreuss vbreuss changed the title Add -EAP to arguments for Qodana Scan Use Qodana EAP to support .NET 8 Nov 19, 2023
@dennisdoomen dennisdoomen requested a review from jnyrup November 20, 2023 06:04
@jnyrup jnyrup merged commit 00e57c9 into fluentassertions:develop Nov 20, 2023
@jnyrup jnyrup added the building Building and Infrastructure of Fluent Assertions label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

building Building and Infrastructure of Fluent Assertions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vbreuss @coveralls @dennisdoomen @jnyrup