Split ObjectAssertionSpecs in multiple files#2416
Split ObjectAssertionSpecs in multiple files#2416dennisdoomen merged 1 commit intofluentassertions:developfrom vbreuss:topic/split-objectassertionspecs
Conversation
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
Pull Request Test Coverage Report for Build 6683878417
💛 - Coveralls |
jnyrup
left a comment
jnyrup
left a comment
There was a problem hiding this comment.
For reference: this work started with the discussion in #1551.
We didn't create any guidelines back then on when we considered a test class of nested classes eligible to be split into separate files.
Some shell scripts I made while looking into this:
Longest file lengths:
find . -name "*.cs" -exec wc -l {} + | head -n -1 | sort -n | grep -vEi '\.[a-z]+\.cs'Most nested classes:
grep -rEc --include=*.cs '^ public class' | grep -vEi '(\.[a-z]+\.cs|:[01]$)' | sort -t':' -k 2 -n
4 participants
Split the huge
ObjectAssertionSpecsfile into multiple partial classes, similar to the change in #1903 forStringAssertionSpecs.IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome