Skip to content

Add release notes for #2393#2396

Merged
jnyrup merged 2 commits intofluentassertions:developfrom
IT-VBFK:fix/release-notes
Oct 20, 2023
Merged

Add release notes for #2393#2396
jnyrup merged 2 commits intofluentassertions:developfrom
IT-VBFK:fix/release-notes

Conversation

@IT-VBFK
Copy link
Copy Markdown
Contributor

@IT-VBFK IT-VBFK commented Oct 19, 2023

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@IT-VBFK IT-VBFK mentioned this pull request Oct 19, 2023
Merged
7 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 19, 2023 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

dennisdoomen
dennisdoomen approved these changes Oct 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks a bit unconventional.

ITaluone
ITaluone reviewed Oct 20, 2023
View reviewed changes
@IT-VBFK
Copy link
Copy Markdown
Contributor Author

IT-VBFK commented Oct 20, 2023

As I mentioned in 2393.. it's a propsal 😉

jnyrup
jnyrup reviewed Oct 20, 2023
View reviewed changes
@IT-VBFK @jnyrup
Update releases.md
43e5f54 
Co-authored-by: Jonas Nyrup <[email protected]>
@jnyrup jnyrup merged commit 63c96fa into fluentassertions:develop Oct 20, 2023
@IT-VBFK IT-VBFK deleted the fix/release-notes branch October 21, 2023 09:51
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@IT-VBFK @jnyrup
Add release notes for fluentassertions#2393 (fluentassertions#2396)
3948d28 
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <[email protected]>

---------

Co-authored-by: Jonas Nyrup <[email protected]>
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@IT-VBFK @jnyrup
Add release notes for fluentassertions#2393 (fluentassertions#2396)
5c5b05e 
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <[email protected]>

---------

Co-authored-by: Jonas Nyrup <[email protected]>
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@IT-VBFK @jnyrup
Add release notes for fluentassertions#2393 (fluentassertions#2396)
5bf7741 
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <[email protected]>

---------

Co-authored-by: Jonas Nyrup <[email protected]>
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@IT-VBFK @jnyrup
Add release notes for fluentassertions#2393 (fluentassertions#2396)
595fac3 
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <[email protected]>

---------

Co-authored-by: Jonas Nyrup <[email protected]>
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@IT-VBFK @jnyrup
Add release notes for fluentassertions#2393 (fluentassertions#2396)
5fc4884 
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <[email protected]>

---------

Co-authored-by: Jonas Nyrup <[email protected]>
jnyrup added a commit that referenced this pull request Sep 9, 2024
@IT-VBFK @jnyrup
Add release notes for #2393 (#2396)
fc3a2e4 
* Add release notes for #2393

* Update releases.md

Co-authored-by: Jonas Nyrup <[email protected]>

---------

Co-authored-by: Jonas Nyrup <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

+1 more reviewer

@ITaluone ITaluone ITaluone left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IT-VBFK @dennisdoomen @jnyrup @ITaluone