Add a note to XML-docs that explains the (Not)ContainEquivalentOf problem#2354
Conversation
(Not)ContainEquivalentOf p…(Not)ContainEquivalentOf problem
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
a00dea9 to
1b2bab6
Compare
Pull Request Test Coverage Report for Build 6448433890
💛 - Coveralls |
Src/FluentAssertions/Collections/GenericCollectionAssertions.cs
Outdated
Show resolved
Hide resolved
40cebde to
1c57cb0
Compare
Src/FluentAssertions/Collections/GenericCollectionAssertions.cs
Outdated
Show resolved
Hide resolved
Not to my knowledge. |
|
What about this? I moved the "Important" /// <summary>
/// Asserts that a collection of objects contains at least one object equivalent to another object.
/// <br />
/// <para>
/// <strong><b>Important:</b></strong> You cannot use this method to assert whether a collection contains a subset of another collection.
/// Use e.g. <see cref="BeSubsetOf"/> instead.
/// </para>
/// </summary>
/// <remarks>
/// <para>
/// By default, objects within the collection are seen as equivalent to the expected object when both object graphs have equally named properties with the same
/// value, irrespective of the type of those objects.
/// Notice that actual behavior is determined by the global defaults managed by <see cref="AssertionOptions"/>.
/// </para>
/// </remarks>
/// <param name="expectation">The expected element.</param>
/// <param name="because">
/// A formatted phrase as is supported by <see cref="string.Format(string,object[])" /> explaining why the assertion
/// is needed. If the phrase does not start with the word <i>because</i>, it is prepended automatically.
/// </param>
/// <param name="becauseArgs">
/// Zero or more objects to format using the placeholders in <paramref name="because"/>.
/// </param> |
I think what I had was bettter, since it explicitly referred to the parameter. |
1a79f4e to
cae2075
Compare
|
Yeah.. I had the same feelings. I will stick with |
e0c4f2e to
d12b007
Compare
Src/FluentAssertions/Collections/GenericCollectionAssertions.cs
Outdated
Show resolved
Hide resolved
d12b007 to
ebbdfef
Compare
Src/FluentAssertions/Collections/GenericCollectionAssertions.cs
Outdated
Show resolved
Hide resolved
ebbdfef to
6b2ef11
Compare







This ref. and hopefully closes #2352
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome