Remove obsolete OrEqualTo methods#2269
Merged
dennisdoomen merged 8 commits intofluentassertions:developfrom Sep 3, 2023
Merged
Remove obsolete OrEqualTo methods#2269dennisdoomen merged 8 commits intofluentassertions:developfrom
OrEqualTo methods#2269dennisdoomen merged 8 commits intofluentassertions:developfrom
Conversation
IT-VBFK
changed the title
IT-VBFK
changed the title
OrEqualTo methods
Pull Request Test Coverage Report for Build 5992739567
💛 - Coveralls |
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
IT-VBFK
force-pushed
the
v7_remove-obsolete_OrEqualTo_methods
branch
2 times, most recently
from
4cb2070 to
b6f1650
Compare
IT-VBFK
changed the title
OrEqualTo methodsOrEqualTo methods
dennisdoomen
approved these changes
Aug 23, 2023
jnyrup
reviewed
Aug 27, 2023
Member
jnyrup
left a comment
jnyrup
left a comment
There was a problem hiding this comment.
Thanks 👍
Here's a few more places that needs to be changed as well.
docs/_data/mstest-migration/assert.yml:249: actual.Should().BeLessOrEqualTo(expected);
docs/_data/mstest-migration/assert.yml:261: actual.Should().BeGreaterOrEqualTo(expected);
docs/_data/mstest-migration/assert.yml:297: actual.Should().BeGreaterOrEqualTo(expected);
docs/_data/mstest-migration/assert.yml:309: actual.Should().BeLessOrEqualTo(expected);
docs/_data/tips/collections.yml:123: actual.Count().Should().BeGreaterOrEqualTo(k);
docs/_data/tips/collections.yml:126: actual.Should().HaveCountGreaterOrEqualTo(k);
docs/_data/tips/collections.yml:147: actual.Count().Should().BeLessOrEqualTo(k);
docs/_data/tips/collections.yml:150: actual.Should().HaveCountLessOrEqualTo(k);
Src/FluentAssertions/Numeric/NumericAssertions.cs:230: public AndConstraint<TAssertions> BeLessOrEqualTo
Src/FluentAssertions/Numeric/NumericAssertions.cs:292: public AndConstraint<TAssertions> BeGreaterOrEqualTo
Member
You can always count on @jnyrup to be thorough 😜💪 |
jnyrup
reviewed
Aug 27, 2023
IT-VBFK
force-pushed
the
v7_remove-obsolete_OrEqualTo_methods
branch
from
e59c3bc to
34281cc
Compare
IT-VBFK
force-pushed
the
v7_remove-obsolete_OrEqualTo_methods
branch
from
34281cc to
d62eaa2
Compare
Co-authored-by: Jonas Nyrup <[email protected]>
IT-VBFK
force-pushed
the
v7_remove-obsolete_OrEqualTo_methods
branch
from
d62eaa2 to
0925d9f
Compare
Contributor
Author
|
Can anybody get this Qodana issues? 😂 This files don't exist anymore... Ah.. nevermind.. They are gone now :) |
jnyrup
approved these changes
Sep 3, 2023
cmeeren
pushed a commit
to cmeeren/fluentassertions
that referenced
this pull request
Sep 18, 2023
* Remove obsolete `OrEqualTo`: `GenericCollectionAssertions` * Remove obsolete `OrEqualTo`: `ComparableTypeAssertions` * Remove obsolete `OrEqualTo`: `SimpleTimeSpanAssertions` * Remove obsolete `OrEqualTo`: `ExecutionTimeAssertions` * Remove obsolete `OrEqualTo`: `NumericAssertions` * Accept API changes * Update releases.md Co-authored-by: Jonas Nyrup <[email protected]> * Fix migration docs --------- Co-authored-by: Jonas Nyrup <[email protected]>
This was referenced Mar 23, 2026
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refs: #1677
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome