Skip to content

DataRowCollection: Set operations#1894

Closed
logiclrd wants to merge 1 commit intofluentassertions:developfrom
logiclrd:JDG_DataSetCollectionSetOperations
Closed

DataRowCollection: Set operations#1894
logiclrd wants to merge 1 commit intofluentassertions:developfrom
logiclrd:JDG_DataSetCollectionSetOperations

Conversation

@logiclrd
Copy link
Copy Markdown
Contributor

@logiclrd logiclrd commented Apr 16, 2022 •
edited
Loading

This PR adds functionality on top of the DataSet assertions which was originally written for #1812 but which got moved out for its own independent pull request/evaluation. The changes add some set assertions to the collection types, modelled after the generic collection set operations, and include unit tests and documentation.

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

@logiclrd
Reintroduced set operations into DataRowCollectionAssertionExtensions…
b1e7d83 
….cs and corresponding tests in DataRowCollectionAssertionExtensionsSpecs.cs.

Reran AcceptApiChanges.ps1.
Updated releases.md to describe this change.
Updated data.md to describe this functionality.
@logiclrd logiclrd changed the title Reintroduced set operations into DataRowCollectionAssertionExtensions… Set operations in DataRowCollectionAssertionExtensions Apr 16, 2022
@logiclrd logiclrd changed the title Set operations in DataRowCollectionAssertionExtensions DataRowCollection: Set operations Apr 16, 2022
@jnyrup
Copy link
Copy Markdown
Member

jnyrup commented Apr 16, 2022 •
edited
Loading

Please open a new issue where we can discuss only the APIs.
Separating API review from implementation API is less time-consuming for us, and hopefully also for you.

I'm writing guidelines for this as we speak, but https://github.com/dotnet/runtime/blob/main/docs/project/api-review-process.md should provide the gist of it.

@logiclrd logiclrd mentioned this pull request Apr 16, 2022
Closed
@logiclrd
Copy link
Copy Markdown
Contributor Author

logiclrd commented Apr 16, 2022

I have created an issue: #1896.

@jnyrup
Copy link
Copy Markdown
Member

jnyrup commented Oct 1, 2022

Closing as API proposal was closed

@jnyrup jnyrup closed this Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@logiclrd @jnyrup