I don't know how to arrange a test for ThrowIfArgumentIsOutOfRange.. Because T is an enum

I don't know how to arrange a test for ThrowIfArgumentIsOutOfRange.. Because T is an enum

Cast any enum to a value that's not listed. For example (CSharpAccessModifier)1000

ahh.. thank you :)

To be honest, I see no value in those extra tests. This is internal code that is already covered by all other code and only exists because of that other code. In fact, ThrowIfArgumentContainsNull can even be removed since it is dead code anyway.

Ok, removing dead code counts as "improve code coverage" IMO :)

But: I search for of this method.. I found four references (MethodInfoSelector, TypeSelectorAssertions, TypeSelector and PropertyInfoSelector)

I will check this tomorrow if this will have a negative side effect if I remove them..

There's an overload.

How I can see the code coverage on coveralls for the latest CI build?

I've just started the CI pipeline.
Once it's done in ~10min the Coveralls bot will post a comment in this PR with a summary of the results.
To view the individual files you'll have to login to Coveralls with your GitHub account.

For the second latest commit, https://coveralls.io/builds/47906682/source?filename=Src%2FFluentAssertions%2FCommon%2FGuard.cs

And if you can't wait for the bot to post, here are the change for Guard.cs
https://coveralls.io/builds/47932197/source?filename=Src%2FFluentAssertions%2FCommon%2FGuard.cs

Instead of adding tests of ThrowIfArgumentContainsNull<T>(IEnumerable<T> values, string paramName, string message) we could delete it, as it is dead code.

According to https://coveralls.io/builds/47932179/source?filename=Src%2FFluentAssertions%2FCommon%2FGuard.cs#L58
all the other lines are already covered by other tests.

Instead of adding tests of ThrowIfArgumentContainsNull<T>(IEnumerable<T> values, string paramName, string message) we could delete it, as it is dead code.

That's exactly what I said ;-)

However, I don't get why Coverall did not post an update here. @eNeRGy164 any idea why it sometimes works and sometimes doesn't?

There's an overload.

Here is an example of what I have thought about to be able to remove ThrowIfArgumentContainsNull<T>().

This applies to all four assertions..

public MethodInfoSelector(IEnumerable<Type> types)
{
    types.ToList()
        .ForEach(type => Guard.ThrowIfArgumentIsNull(type, nameof(type)));
    Guard.ThrowIfArgumentIsNull(types, nameof(types));

    selectedMethods = types.SelectMany(t => t
        .GetMethods(BindingFlags.DeclaredOnly | BindingFlags.Instance | BindingFlags.Static | BindingFlags.Public | BindingFlags.NonPublic)
        .Where(method => !HasSpecialName(method)));
}

because removing the overload would be a breaking change IMO

It's non-breaking to remove any unused members of Guard since the class is internal.

So public static void ThrowIfArgumentContainsNull<T>(IEnumerable<T> values, string paramName) should be kept as it is used.

public static void ThrowIfArgumentContainsNull<T>(IEnumerable<T> values, string paramName, string message) can be removed as it unused and not public because Guard is internal.

Maybe you're using an IDE that doesn't allow you to find usages, but my IDE (Rider) clearly tells me that the overload of ThrowIfArgumentContainsNull that takes three parameters isn't used at all.

ok, that was completely my fault 🙈

I have written the tests and therefore it showes up "2 usages".. (the tests)

I should have checked that before writing the tests :D

However, I don't get why Coverall did not post an update here. @eNeRGy164 any idea why it sometimes works and sometimes doesn't?

At first, there was no run CI initiated by default because it's @ITaluone's first contribution.
But why there was no post after the actual run, I also don't know. I can only guess that maybe the API between Coveralls and GitHub is overloaded or something like that. Can't see anything specific.
I have seen posts appear when refreshing coveralls sync with GH in the past.

I should have checked that before writing the tests :D

Those tests can be removed anyway.

ok, got it