Update PropertyInfoSelector assertions#1565
Merged
jnyrup merged 2 commits intofluentassertions:developfrom May 20, 2021
eNeRGy164:robust-propertyinfo-selector-assertions
Merged
Update PropertyInfoSelector assertions#1565jnyrup merged 2 commits intofluentassertions:developfrom eNeRGy164:robust-propertyinfo-selector-assertions
jnyrup merged 2 commits intofluentassertions:developfrom
eNeRGy164:robust-propertyinfo-selector-assertions
Conversation
Member
dennisdoomen
left a comment
dennisdoomen
left a comment
There was a problem hiding this comment.
I wonder whether it was worth the trouble. Especially since you're now directly testing the internal
Tests/FluentAssertions.Specs/Types/PropertyInfoSelectorAssertionSpecs.cs
Outdated
Show resolved
Hide resolved
jnyrup
reviewed
May 17, 2021
Member
jnyrup
left a comment
jnyrup
left a comment
There was a problem hiding this comment.
Just a single question, otherwise I like this approach 👍
jnyrup
approved these changes
May 19, 2021
3 tasks
dennisdoomen
approved these changes
May 20, 2021
| PropertyInfoSelector propertyInfoSelector; | ||
|
|
||
| // Act | ||
| Action act = () => propertyInfoSelector = new PropertyInfoSelector((Type)null); |
Member
There was a problem hiding this comment.
I'm still uncomfortable directly using the "internal" types in tests, but we have no clear guidance on what we should and should not do.
jnyrup
approved these changes
May 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More coverage of #1039
All these null reference exception paths.. already made me doubt TDD practices since a training on 27 Februari 2010 in Doorn 😉
IMPORTANT