Limit formatting to a maximum number of lines#1469
Merged
dennisdoomen merged 4 commits intofluentassertions:developfrom Apr 19, 2021
Merged
Limit formatting to a maximum number of lines#1469dennisdoomen merged 4 commits intofluentassertions:developfrom
dennisdoomen merged 4 commits intofluentassertions:developfrom
Conversation
dennisdoomen
force-pushed
the
Fix/1014
branch
4 times, most recently
from
853b05d to
0f80f4f
Compare
dennisdoomen
force-pushed
the
Fix/1014
branch
4 times, most recently
from
5274aa1 to
21f13d6
Compare
jnyrup
reviewed
Mar 3, 2021
dennisdoomen
force-pushed
the
Fix/1014
branch
3 times, most recently
from
735cafa to
7ab46cf
Compare
dennisdoomen
force-pushed
the
Fix/1014
branch
5 times, most recently
from
4941255 to
d474a26
Compare
dennisdoomen
force-pushed
the
Fix/1014
branch
2 times, most recently
from
523a423 to
f9cf9cc
Compare
dennisdoomen
force-pushed
the
Fix/1014
branch
9 times, most recently
from
788a6e0 to
d8f7aca
Compare
Those options can be used to tweak the MaxDepth and the UseLineBreaks that the formatter uses to render the object graph in case an assertion fails.
dennisdoomen
force-pushed
the
Fix/1014
branch
3 times, most recently
from
a97c3d3 to
46f2f9b
Compare
dennisdoomen
changed the title
dennisdoomen
changed the title
jnyrup
reviewed
Apr 17, 2021
jnyrup
reviewed
Apr 18, 2021
Member
jnyrup
left a comment
jnyrup
left a comment
There was a problem hiding this comment.
As requested, here's your additional "shitload of comments"
Tests/Approval.Tests/ApprovedApi/FluentAssertions/net47.verified.txt
Outdated
Show resolved
Hide resolved
jnyrup
reviewed
Apr 18, 2021
Tests/Approval.Tests/ApprovedApi/FluentAssertions/net47.verified.txt
Outdated
Show resolved
Hide resolved
jnyrup
approved these changes
Apr 18, 2021
Member
jnyrup
left a comment
jnyrup
left a comment
There was a problem hiding this comment.
Awesome!
I can't wait to see some failing unit tests
dennisdoomen
force-pushed
the
Fix/1014
branch
2 times, most recently
from
d92d631 to
d38f25a
Compare
Member
|
Just noticed that the docs also needs an update. |
Member
Author
Damnit. I already did the work to update the extensibility guide and add a section to the tips for migrating to v6. I must have force pushed something away. |
jnyrup
reviewed
Apr 18, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both will have defaults
Fixes #1014
Can be reviewed commit by commit