When a dictionary does not a key, it should report the right path including the reason#1454
Merged
dennisdoomen merged 1 commit intofluentassertions:developfrom Jan 8, 2021
Merged
Conversation
dennisdoomen
changed the title
jnyrup
approved these changes
Jan 6, 2021
Member
jnyrup
left a comment
jnyrup
left a comment
There was a problem hiding this comment.
The commit message probably misses a "contains".
"When a dictionary does not a key, it should report the right path"
Feel free to leave it.
Member
Author
|
Yes, but I also decided to fix #1449 in the same PR tomorrow. That's why I removed the review request ;-) |
Member
|
Didn't see my removal and adding of [WIP] before I starting reviewing :) |
dennisdoomen
force-pushed
the
Fix/1450
branch
2 times, most recently
from
6712e0e to
854d69d
Compare
dennisdoomen
changed the title
dennisdoomen
changed the title
dennisdoomen
changed the title
dennisdoomen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes BeEquivalentTo reported an incorrect message when a dictionary was missing a key.
Fixes #1450