Improve XML assertion messages#1440
Conversation
Great initiative.
Don't think so. Also, the 2nd commit seems to contain unrelated changes. In other words, you've changed the expected output in the specs, but there are no other changes that are the cause of this. |
|
The second commit contains change of test and change using |
Yes, so it's weird that you had to change a test even though nothing changed in that commit. So I fail to understand why you were asking about the commits. |
|
The commits are doing what their commit message reports:
Regarding changelog this could be two changes or a single one. |
|
We must be on the wrong channel ;-) The 2nd commit updates |
|
Thanks for giving the xml assertions and specs some needed love. I think the two commits are so closely related, that the single release note covers them both - and that's fine by me. |
I was triggered by reading #1353 that most XML assertion messages does not include variable name too.
So I've started reworking these assertions to
While reviewing the texts in the unit tests I found some messages which are misleading because the XmlValidator was following the subject instead of the expectation.
You may want to review the two commits separately.
I'll add changelog when the PR number is available...
Should these two commits result into two statements in the changelog?