Fix #1427 Add DateTime.Should().Be(DateTime?) and DateTimeOffset.Should().Be(DateTimeOffset?) overloads#1432
Merged
dennisdoomen merged 5 commits intofluentassertions:developfrom Nov 18, 2020
facundo91:Fix#1427
Merged
Fix #1427 Add DateTime.Should().Be(DateTime?) and DateTimeOffset.Should().Be(DateTimeOffset?) overloads#1432dennisdoomen merged 5 commits intofluentassertions:developfrom facundo91:Fix#1427
DateTime.Should().Be(DateTime?) and DateTimeOffset.Should().Be(DateTimeOffset?) overloads#1432dennisdoomen merged 5 commits intofluentassertions:developfrom
facundo91:Fix#1427
Conversation
…hould().Be(DateTimeOffset?)` overloads
dennisdoomen
approved these changes
Nov 17, 2020
Member
dennisdoomen
left a comment
dennisdoomen
left a comment
There was a problem hiding this comment.
Nice PR. Just some nitpicking/suggestions if you're up to it.
Tests/FluentAssertions.Specs/Primitives/DateTimeAssertionSpecs.cs
Outdated
Show resolved
Hide resolved
Tests/FluentAssertions.Specs/Primitives/DateTimeAssertionSpecs.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you for the suggestions @dennisdoomen , it is now ready to be merge. |
jnyrup
reviewed
Nov 17, 2020
Member
jnyrup
left a comment
jnyrup
left a comment
There was a problem hiding this comment.
Not crucial, but would be nice with tests exercising subject, expected or both being null.
jnyrup
approved these changes
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
DateTime.Should().Be(DateTime?)andDateTimeOffset.Should().Be(DateTimeOffset?)overloadsFixes #1427
To mimic the behavior of NumericAssertions, I have added the cases marked in bold to
DateTimeAssertionsandDateTimeOffsetAssertions. Below examples are for Datetime, but same logic was followed for DatetimeOffset.subject.Be(expected)
subject.NotBe(expected)
IMPORTANT
AcceptApiChanges.ps1/AcceptApiChanges.sh.