Add NotBeEquivalentTo with config overload#1408
Merged
jnyrup merged 1 commit intofluentassertions:developfrom Oct 13, 2020
Merged
Add NotBeEquivalentTo with config overload#1408jnyrup merged 1 commit intofluentassertions:developfrom
jnyrup merged 1 commit intofluentassertions:developfrom
Conversation
jnyrup
force-pushed
the
NotBeEquivalentTo
branch
from
694562c to
dcdb744
Compare
dennisdoomen
approved these changes
Oct 13, 2020
jnyrup
force-pushed
the
NotBeEquivalentTo
branch
from
dcdb744 to
45e2473
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an overloads of
CollectionAssertions.BeEquivalentTothat takes aconfigparameter.Since #593
CollectionAssertions.BeEquivalentTono longer usedGetMissingItems.https://github.com/fluentassertions/fluentassertions/pull/593/files?file-filters%5B%5D=#diff-4cf34d1b2865162998773f88349aecab.
The same removal should be done here, as
GetMissingItemsrelies onContainswhich checks for equality and not equivalence.