Guard [Not]Match, [Not]MatchEquivalentOf, [Not]MatchRegex and [Not]ContainMatch against null or empty patterns#1401
Merged
dennisdoomen merged 1 commit intofluentassertions:developfrom Oct 5, 2020
eNeRGy164:match-null-exception
Merged
Guard [Not]Match, [Not]MatchEquivalentOf, [Not]MatchRegex and [Not]ContainMatch against null or empty patterns#1401dennisdoomen merged 1 commit intofluentassertions:developfrom eNeRGy164:match-null-exception
dennisdoomen merged 1 commit intofluentassertions:developfrom
eNeRGy164:match-null-exception
Conversation
…null or empty patterns
jnyrup
approved these changes
Oct 5, 2020
Member
jnyrup
left a comment
There was a problem hiding this comment.
Looks good and really nice with the guidance to users of which assertion method they should rather be using.
dennisdoomen
approved these changes
Oct 5, 2020
Member
I second that. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
Stringassertions,[Not]Match,[Not]MatchEquivalentOf,[Not]MatchRegexand[Not]ContainMatchno longer accept anullor empty string as parameter.The exception suggests to add a pattern or use one of the
[Not]BeNull,[Not]BeEmptyor[Not]Containmethods if that behavior was intended.Should also close #1243
IMPORTANT
AcceptApiChanges.ps1/AcceptApiChanges.sh.