Skip to content

Allow using custom IOrderingRule#1337

Merged
dennisdoomen merged 3 commits intofluentassertions:developfrom
philippdolder:register-custom-ordering-rule
May 27, 2020
Merged

Allow using custom IOrderingRule#1337
dennisdoomen merged 3 commits intofluentassertions:developfrom
philippdolder:register-custom-ordering-rule

Conversation

@philippdolder
Copy link
Copy Markdown
Contributor

@philippdolder philippdolder commented May 26, 2020

Fixes #1336

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used in this example.
  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

dennisdoomen
dennisdoomen reviewed May 26, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor commentss

@jnyrup
Copy link
Copy Markdown
Member

jnyrup commented May 26, 2020

Please add a line to docs/_pages/releases.md about the addition.
I'll add it to CONTRIBUTING.md immediately.

@philippdolder philippdolder requested a review from jnyrup May 27, 2020 06:19
@dennisdoomen
Copy link
Copy Markdown
Member

dennisdoomen commented May 27, 2020

Thanks for this contribution @philippdolder

@dennisdoomen dennisdoomen merged commit 599f606 into fluentassertions:develop May 27, 2020
@philippdolder philippdolder deleted the register-custom-ordering-rule branch May 27, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow to configure custom IOrderingRule

3 participants

@philippdolder @jnyrup @dennisdoomen