Fix XPath index calculation for XML comparison#1273
Merged
jnyrup merged 3 commits intofluentassertions:masterfrom Mar 21, 2020
Merged
Fix XPath index calculation for XML comparison#1273jnyrup merged 3 commits intofluentassertions:masterfrom
jnyrup merged 3 commits intofluentassertions:masterfrom
Conversation
dennisdoomen
approved these changes
Mar 20, 2020
jnyrup
requested changes
Mar 20, 2020
Member
jnyrup
left a comment
There was a problem hiding this comment.
Just to small typos and thanks for adding the missing release notes 👍
jnyrup
reviewed
Mar 20, 2020
lg2de
commented
Mar 20, 2020
jnyrup
approved these changes
Mar 20, 2020
Member
|
@lg2de would you be willing to create a pull request from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last year I provided rework of the assertion failure message when comparing XML by introducing XPath index.
Now I found that the current implementation can generate invalid XPath. The index could should apply to the parent.
This PR replaces #1272 to target 5.X
Input
Compare
with
Expected behavior
Expected attribute "a" at "/root/xml1[3]/xml2[2]" to have value "y", but found "x".
Actual behavior
Expected attribute "a" at "/root/xml1[3]/xml2[4]" to have value "y", but found "x".