Fix XPath index calculation for XML comparison#1272
Closed
lg2de wants to merge 2 commits intofluentassertions:developfrom
Closed
Fix XPath index calculation for XML comparison#1272lg2de wants to merge 2 commits intofluentassertions:developfrom
lg2de wants to merge 2 commits intofluentassertions:developfrom
Conversation
dennisdoomen
approved these changes
Mar 19, 2020
Contributor
Author
|
Maybe release notes are missing. |
jnyrup
approved these changes
Mar 19, 2020
Member
jnyrup
left a comment
There was a problem hiding this comment.
Love that the fix is so simple 👍
Member
But then you have to target |
Member
|
We can close this one, right? |
Contributor
Author
|
replaced by #1273 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last year I provided rework of the assertion failure message when comparing XML by introducing XPath index.
Now I found that the current implementation can generate invalid XPath. The index could should apply to the parent.
Input
Compare
with
Expected behavior
Expected attribute "a" at "/root/xml1[3]/xml2[2]" to have value "y", but found "x".
Actual behavior
Expected attribute "a" at "/root/xml1[3]/xml2[4]" to have value "y", but found "x".