Skip to content

Add PropertyInfoSelectorAssertions.NotBeWritable#1269

Merged
jnyrup merged 3 commits intofluentassertions:developfrom
dramurai:add_not_be_writable_to_property_info_selector_assertions
Mar 12, 2020
Merged

Add PropertyInfoSelectorAssertions.NotBeWritable#1269
jnyrup merged 3 commits intofluentassertions:developfrom
dramurai:add_not_be_writable_to_property_info_selector_assertions

Conversation

@dramurai
Copy link
Copy Markdown
Contributor

@dramurai dramurai commented Mar 11, 2020

Add assertion method NotBeWritable to PropertyInfoSelectorAssertions.

Closes #1256

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used in this example.
  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

@dramurai
Add PropertyInfoSelectorAssertions.NotBeWritable
e796563 
Add assertion method NotBeWritable to PropertyInfoSelectorAssertions.
jnyrup
jnyrup approved these changes Mar 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was fast!

@dramurai
Copy link
Copy Markdown
Contributor Author

dramurai commented Mar 11, 2020

Thanks for the compliment. I cheated a bit and familiarized myself with the code earlier and most of the work had already by been done when implementing BeWritable 😉

@jnyrup
Copy link
Copy Markdown
Member

jnyrup commented Mar 11, 2020

Could I ask you to add a line to docs/_pages/releases.md as well?

@dramurai
Update releases.md
2b114ac 
Add NotBeWritable to What's New section.
dennisdoomen
dennisdoomen approved these changes Mar 12, 2020
View reviewed changes
@jnyrup jnyrup merged commit 26a5906 into fluentassertions:develop Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PropertyInfoSelectorAssertions.NotBeWritable?

3 participants

@dramurai @jnyrup @dennisdoomen