Using/When in BeEquivalentTo will respect the conversion rules. #1257
Merged
dennisdoomen merged 2 commits intofluentassertions:developfrom Feb 23, 2020
Merged
Conversation
dennisdoomen
force-pushed
the
Fix/ConversionOfCustomRules
branch
from
36163e8 to
d0a1245
Compare
jnyrup
requested changes
Feb 21, 2020
Tests/Shared.Specs/Equivalency/ExtensibilityRelatedEquivalencySpecs.cs
Outdated
Show resolved
Hide resolved
Src/FluentAssertions/Equivalency/AssertionRuleEquivalencyStep.cs
Outdated
Show resolved
Hide resolved
Src/FluentAssertions/Equivalency/AssertionRuleEquivalencyStep.cs
Outdated
Show resolved
Hide resolved
Src/FluentAssertions/Equivalency/CollectionMemberAssertionOptionsDecorator.cs
Show resolved
Hide resolved
* If both subject and expectation are DateTimes, use the Using * If WithAutoConversion is enabled, try to convert subject into the type of expectation * If, after conversion, both the converted subject and the expectation are DateTimes, use the Using fixup! Using/When in BeEquivalentTo will respect the conversion rules.
dennisdoomen
force-pushed
the
Fix/ConversionOfCustomRules
branch
from
d0a1245 to
25e39bd
Compare
jnyrup
approved these changes
Feb 22, 2020
dennisdoomen
force-pushed
the
Fix/ConversionOfCustomRules
branch
from
25e39bd to
1d51f5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the functionality as suggested by @jnyrup in #876.
DateTimes, use theUsingWithAutoConversionis enabled, try to convert subject into the type of expectationDateTimes, use theUsingAlso fixes the API approval script.