Fix unexpected IsDotNet behavior for non-dotnet namespaces#1193
Merged
jnyrup merged 2 commits intofluentassertions:masterfrom Nov 27, 2019
Merged
Fix unexpected IsDotNet behavior for non-dotnet namespaces#1193jnyrup merged 2 commits intofluentassertions:masterfrom
jnyrup merged 2 commits intofluentassertions:masterfrom
Conversation
Member
|
Thanks for pointing this out and submitting a PR. Side note: Less than three weeks ago the same flawed logic was discovered for |
Contributor
Author
|
@jnyrup sure I'll give it a try. Any suggestions on where to write the unit tests? |
Member
|
We don't seem to have tests targeting |
Contributor
Author
|
Hopefully this does it, but I have my doubts :) I'm quite new to unit testing as well as this library. Testing the thing that you use to test certainly makes it a bit more confusing 🥴 No idea why the appveyor build fails as it works fine for me locally with |
dennisdoomen
approved these changes
Nov 27, 2019
jnyrup
approved these changes
Nov 27, 2019
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check in
IsDotNetonly checks if the namespace starts with "System" which can cause non-dotnet namespaces likeSystemSomething.RestApito return true unexpectedly.I struggled with this one at work today for a few hours as our product name (and therefor our namespaces) are
SystemProductName.RestApi. I noticed it because the variable names were missing from our failing asserts even when building in debug mode.IMPORTANT