Fix comparison of empty multi-dimensional arrays#1169
Merged
jnyrup merged 1 commit intofluentassertions:masterfrom Oct 26, 2019
Merged
Fix comparison of empty multi-dimensional arrays#1169jnyrup merged 1 commit intofluentassertions:masterfrom
jnyrup merged 1 commit intofluentassertions:masterfrom
Conversation
Member
Author
|
The failing test is |
Member
Sigh. I thought we fixed this by now. |
Member
Author
|
|
When comparing multi-dimensional `Array`s using `BeEquivalentTo` we weren't handling the case of empty `Array`s, which threw an `IndexOutOfRangeException` when it tried to get an element. This fixes fluentassertions#1167
jnyrup
force-pushed
the
EmptyMultidimensionalArrays
branch
from
f27fda9 to
78dc823
Compare
dennisdoomen
approved these changes
Oct 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When comparing multi-dimensional
Arrays usingBeEquivalentTowe weren't handling the case of empty
Arrays, which threw anIndexOutOfRangeExceptionwhen it tried to get an element.This fixes #1167