Fix timing issues with Should().NotThrowAfter()#1076
Merged
dennisdoomen merged 2 commits intofluentassertions:masterfrom Jun 7, 2019
Merged
Fix timing issues with Should().NotThrowAfter()#1076dennisdoomen merged 2 commits intofluentassertions:masterfrom
dennisdoomen merged 2 commits intofluentassertions:masterfrom
Conversation
dennisdoomen
force-pushed
the
FixTiming
branch
3 times, most recently
from
461a2c6 to
f0ecd17
Compare
lg2de
reviewed
Jun 5, 2019
Contributor
lg2de
left a comment
lg2de
left a comment
There was a problem hiding this comment.
Instead of "mystic" calculation of now in the TestingTimer I would prefer explicit control of timing within the tests.
dennisdoomen
changed the title
jnyrup
reviewed
Jun 5, 2019
For some reason, the formatting specs that change global state are executed in a different order sometimes. This revealed a unexpected side-effect of changing the global configuration.
jnyrup
requested changes
Jun 6, 2019
jnyrup
approved these changes
Jun 6, 2019
Member
jnyrup
left a comment
jnyrup
left a comment
There was a problem hiding this comment.
But my two last comments still holds :)
Member
Author
Which ones? I applied all your suggestions. |
jnyrup
requested changes
Jun 7, 2019
jnyrup
approved these changes
Jun 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended the existing
ITimerabstraction and renamed it toIClockso all tests that rely on delays, waits and stopwatches can be tested in a reliable fashion. This should resolve the flakiness we've been experiences.IMPORTANT
masterbranch.