Refactoring of AsyncFunctionAssertions and ActionAssertions#1054
Merged
dennisdoomen merged 7 commits intofluentassertions:masterfrom May 31, 2019
Merged
Refactoring of AsyncFunctionAssertions and ActionAssertions#1054dennisdoomen merged 7 commits intofluentassertions:masterfrom
dennisdoomen merged 7 commits intofluentassertions:masterfrom
Conversation
davidomid
changed the title
This was referenced May 27, 2019
Member
|
Should we finish/merge #1050 first? |
Contributor
Author
Yes please :) As far as I can tell, it should be fine for you to merge it when ready. Thanks very much |
Contributor
Author
@dennisdoomen I resolved the merge conflicts. Looks good aside from a flaky time-related test now 👍 |
Member
|
You need to rebase it on |
jnyrup
reviewed
May 27, 2019
…y reduced the amount of duplicate methods and error message inconsistencies
jnyrup
approved these changes
May 31, 2019
dennisdoomen
changed the title
dennisdoomen
approved these changes
May 31, 2019
Contributor
Author
|
Please can this be merged? I frequently need to resolve conflicts due to the moving of methods which are edited in other merged pull requests. Failing tests are the flaky ones again. Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #1053
This PR also contains the changes made in PR #1050