Unwrapping of AggregateExceptions#1041
Merged
dennisdoomen merged 1 commit intofluentassertions:masterfrom May 26, 2019
Merged
Conversation
dennisdoomen
approved these changes
May 5, 2019
Member
dennisdoomen
left a comment
There was a problem hiding this comment.
I can't fully predict the effect of these changes. I'll try to run these changes to my current project code-base to see if anything breaks.
Member
Author
|
Found a related issue #696 |
Member
|
Tried to run this PR against the 20K tests of a project I'm involved with and everything seems to be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #1038 got merged, the logic for unwrapping
AggregateExceptionbecomes a lot easier, as we now know that FluentAssertions doesn't wrap exceptions in anAggregateException.Calling
Throw<TException>is designed to also succeed if an exception of typeTExceptionis wrapped inside anAggregateException.The same behavior should be present for
NotThrow<TException>This PR solves these problems.
NotThrow<TException>didn't look insideAggregateExceptions to see if an exception of typeTExceptionwas thrown, which made it non-symmetric toThrow<TException>.GetFirstNonAggregateExceptiononly looked at theInnerExceptionof anAggregateExceptioninstead ofInnerExceptions(all wrapped exceptions). E.g. it failed to handle ifTExceptionwas the secondInnerException.InterceptExceptionunwrapped to much.