-
Notifications
You must be signed in to change notification settings - Fork 732
Contain(IEnumerable<T>, params T[]) lacks because parameter #806
Copy link
Copy link
Closed
Description
The method
public AndConstraint<TAssertions> Contain(IEnumerable<T> expectedItemsList, params T[] additionalExpectedItems);in the class SelfReferencingCollectionAssertions<T, TAssertions> lacks a string because parameter. Probably because additionalExpectedItems is a params.
Suggestions:
- Refactor to:
public AndConstraint<TAssertions> Contain(IEnumerable<T> expectedItemsList, IEnumerable<T>additionalExpectedItems, string because = "", params object[] becauseArgs);Pro's:
- Same signature as other methods
Cons:
- Breaking change
- Add:
public AndConstraint<TAssertions> Contain(IEnumerable<T> expectedItemsList, string because ="", params T[] additionalExpectedItems);Pro's:
- Non-breaking change
Cons:
- No
params object[] becauseArgs - Still does not match other method signatures
Reactions are currently unavailable