1.0: in_tail: Add read_bytes_limit_per_second description #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you resolve the conflict? |
cosmo0920
force-pushed
the
1.0-in_tail-read_bytes_limit_per_second
branch
from
e02f578 to
498d3a1
Compare
Contributor
Author
|
I'd resolved the conflict but this parameter is not supported for now. |
ashie
requested changes
May 10, 2021
Member
ashie
left a comment
ashie
left a comment
There was a problem hiding this comment.
- the range of
read_bytes_limit_per_secondshould be described (>= 8192) max_thread_pool_sizeshould be added too
ashie
reviewed
May 10, 2021
cosmo0920
force-pushed
the
1.0-in_tail-read_bytes_limit_per_second
branch
from
498d3a1 to
08df02e
Compare
ashie
reviewed
May 11, 2021
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
1.0-in_tail-read_bytes_limit_per_second
branch
from
08df02e to
35a7277
Compare
Member
|
I'll merge it after v1.13 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for fluent/fluentd#3185.
Signed-off-by: Hiroshi Hatake [email protected]