Backport(v1.16): test_fluentd: fix assert pattern of syntax error for Ruby HEAD (#4644) #5187
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby parser will be replaced new parser in Ruby 3.4. ruby/ruby@ea2af57 The new parser might not have a fully compatible of Syntax error messages. So I modified the assert pattern to succeed in the Ruby HEAD. ### example ```ruby module Foo class Bar def say puts "hello" end end ``` ### result with Ruby 3.3.5 ``` $ ruby -v test.rb ruby 3.3.5 (2024-09-03 revision ef084cc8f4) [x86_64-linux] test.rb: --> test.rb Unmatched keyword, missing `end' ? > 1 module Foo test.rb:6: syntax error, unexpected end-of-input, expecting `end' or dummy end (SyntaxError) end ^ ``` ### result with Ruby 3.4-dev ```ruby ruby -v test.rb ruby 3.4.0dev (2024-09-25T02:45:33Z master 76543a34ab) +PRISM [x86_64-linux] test.rb: --> test.rb Unmatched keyword, missing `end' ? > 1 module Foo test.rb:7: syntax errors found (SyntaxError) 5 | end 6 | end > 7 | | ^ expected an `end` to close the `module` statement | ^ unexpected end-of-input, assuming it is closing the parent top level context ``` Ruby 3.3.5 has `test.rb:6: syntax error,..`, but Ruby 3.4-dev has `test.rb:7: syntax errors...`. Signed-off-by: Shizuo Fujita <[email protected]>
daipom
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #4644
Which issue(s) this PR fixes:
Fixes #
Related to #4584
What this PR does / why we need it:
Ruby parser will be replaced new parser in Ruby 3.4. ruby/ruby@ea2af57
The new parser might not have a fully compatible of Syntax error messages.
So I modified the assert pattern to succeed in the Ruby HEAD.
example
result with Ruby 3.3.5
result with Ruby 3.4-dev
Ruby 3.3.5 has
test.rb:6: syntax error,.., but Ruby 3.4-dev hastest.rb:7: syntax errors....Docs Changes:
Release Note: