Skip to content

Conversation

@Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Dec 5, 2025

Which issue(s) this PR fixes:
This patch will fix following failures on Windows with old Ruby (3.0, 2.7).

1) Failure: test_supervisor_event_handler(SupervisorTest): <false> is not true.
D:/a/fluentd/fluentd/test/test_supervisor.rb:388:in `test_supervisor_event_handler'
     385: 
     386:     debug_msg = '[debug]: Got Win32 event "TestFluentdEvent_USR1"'
     387:     logs = $log.out.logs
  => 388:     assert{ logs.any?{|log| log.include?(debug_msg) } }
     389:   ensure
     390:     $log.out.reset if $log&.out&.respond_to?(:reset)
     391:   end

2) Failure: test_windows_shutdown_event(SupervisorTest): <false> is not true.
D:/a/fluentd/fluentd/test/test_supervisor.rb:362:in `test_windows_shutdown_event'
     359: 
     360:     debug_msg = '[debug]: Got Win32 event "TestFluentdEvent"'
     361:     logs = $log.out.logs
  => 362:     assert{ logs.any?{|log| log.include?(debug_msg) } }
     363:   ensure
     364:     $log.out.reset if $log&.out&.respond_to?(:reset)
     365:   end

https://github.com/fluent/fluentd/actions/runs/19950323545/job/57208741261

What this PR does / why we need it:
It seems we need to wait a bit to reliably capture events as logs.

Similar to following codes, this also includes sleep.

sleep 0.1 # Wait for starting windows event thread
event = Win32::Event.open("TestFluentdEvent_CONT")
event.set
event.close
sleep 1.0 # Wait for dumping

Docs Changes:
N/A

Release Note:
N/A

@Watson1978
Copy link
Contributor Author

Ok, this works fine.

Need to create PR to master branch.
Then, backport to v1.16 branch.

@Watson1978 Watson1978 closed this Dec 5, 2025
@Watson1978 Watson1978 deleted the fix-flaky-tests-v1.16 branch December 5, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant