Skip to content

test_dsl: fix test using pipe command #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Watson1978 merged 1 commit into from
Nov 21, 2025
Merged

test_dsl: fix test using pipe command #5160

Watson1978 merged 1 commit into from
Nov 21, 2025

Conversation

@Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Nov 21, 2025

Which issue(s) this PR fixes:
Fixes #5148

What this PR does / why we need it:
Related to #5159
I overlooked the fact that there were also tests using pipe commands in another file.

Since Ruby 4.0, When we give pipe command in Kernel.open, it causes an error.

$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +PRISM [x86_64-linux]
-e:1: warning: Calling Kernel#open with a leading '|' is deprecated and will be removed in Ruby 4.0; use IO.popen instead
"Linux UM890 6.17.1-0-MANJARO #1 SMP PREEMPT_DYNAMIC Tue, 07 Oct 2025 07:57:35 +0000 x86_64 GNU/Linux\n"

$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 4.0.0dev (2025-11-20T00:03:23Z master 167c3dbaa0) +PRISM [x86_64-linux]
-e:1:in 'File#initialize': No such file or directory @ rb_sysopen - | uname -a (Errno::ENOENT)
	from -e:1:in 'Kernel.open'
	from -e:1:in '<main>'

Docs Changes:
N/A

Release Note:
N/A

@Watson1978 Watson1978 requested a review from daipom November 21, 2025 01:16
@Watson1978 Watson1978 added the CI Test/CI issues label Nov 21, 2025
@daipom daipom added this to the v1.20.0 milestone Nov 21, 2025
daipom
daipom approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Watson1978 Watson1978 merged commit 7ba2227 into fluent:master Nov 21, 2025
17 checks passed
@Watson1978 Watson1978 deleted the test_dsl branch November 21, 2025 02:02
@Watson1978 Watson1978 mentioned this pull request Dec 5, 2025
Merged
@Watson1978 Watson1978 added backport to v1.16 We will backport this fix to the LTS branch backport to v1.19 We will backport this fix to the LTS branch labels Dec 5, 2025
Watson1978 added a commit to Watson1978/fluentd that referenced this pull request Dec 5, 2025
@Watson1978
test_dsl: fix test using pipe command (fluent#5160)
c78147c 
**Which issue(s) this PR fixes**:
Fixes fluent#5148

**What this PR does / why we need it**:
Related to fluent#5159
I overlooked the fact that there were also tests using pipe commands in
another file.

Since Ruby 4.0, When we give pipe command in `Kernel.open`, it causes an
error.

```
$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +PRISM [x86_64-linux]
-e:1: warning: Calling Kernel#open with a leading '|' is deprecated and will be removed in Ruby 4.0; use IO.popen instead
"Linux UM890 6.17.1-0-MANJARO #1 SMP PREEMPT_DYNAMIC Tue, 07 Oct 2025 07:57:35 +0000 x86_64 GNU/Linux\n"

$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 4.0.0dev (2025-11-20T00:03:23Z master 167c3dbaa0) +PRISM [x86_64-linux]
-e:1:in 'File#initialize': No such file or directory @ rb_sysopen - | uname -a (Errno::ENOENT)
	from -e:1:in 'Kernel.open'
	from -e:1:in '<main>'
```

**Docs Changes**:
N/A

**Release Note**:
N/A

Signed-off-by: Shizuo Fujita <[email protected]>
Watson1978 added a commit to Watson1978/fluentd that referenced this pull request Dec 8, 2025
@Watson1978
test_dsl: fix test using pipe command (fluent#5160)
a2bd0a4 
**Which issue(s) this PR fixes**: 
Fixes fluent#5148

**What this PR does / why we need it**: 
Related to fluent#5159
I overlooked the fact that there were also tests using pipe commands in
another file.

Since Ruby 4.0, When we give pipe command in `Kernel.open`, it causes an
error.

```
$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +PRISM [x86_64-linux]
-e:1: warning: Calling Kernel#open with a leading '|' is deprecated and will be removed in Ruby 4.0; use IO.popen instead
"Linux UM890 6.17.1-0-MANJARO #1 SMP PREEMPT_DYNAMIC Tue, 07 Oct 2025 07:57:35 +0000 x86_64 GNU/Linux\n"

$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 4.0.0dev (2025-11-20T00:03:23Z master 167c3dbaa0) +PRISM [x86_64-linux]
-e:1:in 'File#initialize': No such file or directory @ rb_sysopen - | uname -a (Errno::ENOENT)
	from -e:1:in 'Kernel.open'
	from -e:1:in '<main>'
```

**Docs Changes**:
N/A

**Release Note**: 
N/A

Signed-off-by: Shizuo Fujita <[email protected]>
Watson1978 added a commit that referenced this pull request Dec 9, 2025
@Watson1978
test_dsl: fix test using pipe command (#5160)
c9775ce 
**Which issue(s) this PR fixes**:
Fixes #5148

**What this PR does / why we need it**:
Related to #5159
I overlooked the fact that there were also tests using pipe commands in
another file.

Since Ruby 4.0, When we give pipe command in `Kernel.open`, it causes an
error.

```
$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +PRISM [x86_64-linux]
-e:1: warning: Calling Kernel#open with a leading '|' is deprecated and will be removed in Ruby 4.0; use IO.popen instead
"Linux UM890 6.17.1-0-MANJARO #1 SMP PREEMPT_DYNAMIC Tue, 07 Oct 2025 07:57:35 +0000 x86_64 GNU/Linux\n"

$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 4.0.0dev (2025-11-20T00:03:23Z master 167c3dbaa0) +PRISM [x86_64-linux]
-e:1:in 'File#initialize': No such file or directory @ rb_sysopen - | uname -a (Errno::ENOENT)
	from -e:1:in 'Kernel.open'
	from -e:1:in '<main>'
```

**Docs Changes**:
N/A

**Release Note**:
N/A

Signed-off-by: Shizuo Fujita <[email protected]>
@Watson1978 Watson1978 mentioned this pull request Dec 9, 2025
Merged
Watson1978 added a commit that referenced this pull request Dec 9, 2025
@Watson1978
test_dsl: fix test using pipe command (#5160)
a5a459f 
**Which issue(s) this PR fixes**:
Fixes #5148

**What this PR does / why we need it**:
Related to #5159
I overlooked the fact that there were also tests using pipe commands in
another file.

Since Ruby 4.0, When we give pipe command in `Kernel.open`, it causes an
error.

```
$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +PRISM [x86_64-linux]
-e:1: warning: Calling Kernel#open with a leading '|' is deprecated and will be removed in Ruby 4.0; use IO.popen instead
"Linux UM890 6.17.1-0-MANJARO #1 SMP PREEMPT_DYNAMIC Tue, 07 Oct 2025 07:57:35 +0000 x86_64 GNU/Linux\n"

$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 4.0.0dev (2025-11-20T00:03:23Z master 167c3dbaa0) +PRISM [x86_64-linux]
-e:1:in 'File#initialize': No such file or directory @ rb_sysopen - | uname -a (Errno::ENOENT)
	from -e:1:in 'Kernel.open'
	from -e:1:in '<main>'
```

**Docs Changes**:
N/A

**Release Note**:
N/A

Signed-off-by: Shizuo Fujita <[email protected]>
@Watson1978 Watson1978 mentioned this pull request Dec 9, 2025
Merged
@Watson1978 Watson1978 added the backported "backport to LTS" is done label Dec 9, 2025
daipom pushed a commit that referenced this pull request Dec 9, 2025
@Watson1978
Backport(v1.16): test_dsl: fix test using pipe command (#5160) (#5183)
0f9ac07 
Backport #5160

**Which issue(s) this PR fixes**:
Fixes #5148

**What this PR does / why we need it**:
Related to #5159
I overlooked the fact that there were also tests using pipe commands in
another file.

Since Ruby 4.0, When we give pipe command in `Kernel.open`, it causes an
error.

```
$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +PRISM [x86_64-linux]
-e:1: warning: Calling Kernel#open with a leading '|' is deprecated and will be removed in Ruby 4.0; use IO.popen instead
"Linux UM890 6.17.1-0-MANJARO #1 SMP PREEMPT_DYNAMIC Tue, 07 Oct 2025 07:57:35 +0000 x86_64 GNU/Linux\n"

$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 4.0.0dev (2025-11-20T00:03:23Z master 167c3dbaa0) +PRISM [x86_64-linux]
-e:1:in 'File#initialize': No such file or directory @ rb_sysopen - | uname -a (Errno::ENOENT)
	from -e:1:in 'Kernel.open'
	from -e:1:in '<main>'
```

**Docs Changes**:
N/A

**Release Note**:
N/A

Signed-off-by: Shizuo Fujita <[email protected]>
daipom pushed a commit that referenced this pull request Dec 9, 2025
@Watson1978
Backport(v1.19): test_dsl: fix test using pipe command (#5160) (#5184)
fe107ca 
Backport #5160

**Which issue(s) this PR fixes**:
Fixes #5148

**What this PR does / why we need it**:
Related to #5159
I overlooked the fact that there were also tests using pipe commands in
another file.

Since Ruby 4.0, When we give pipe command in `Kernel.open`, it causes an
error.

```
$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +PRISM [x86_64-linux]
-e:1: warning: Calling Kernel#open with a leading '|' is deprecated and will be removed in Ruby 4.0; use IO.popen instead
"Linux UM890 6.17.1-0-MANJARO #1 SMP PREEMPT_DYNAMIC Tue, 07 Oct 2025 07:57:35 +0000 x86_64 GNU/Linux\n"

$ ruby -w -v -e "Kernel.open('| uname -a'){|out| p out.read }"
ruby 4.0.0dev (2025-11-20T00:03:23Z master 167c3dbaa0) +PRISM [x86_64-linux]
-e:1:in 'File#initialize': No such file or directory @ rb_sysopen - | uname -a (Errno::ENOENT)
	from -e:1:in 'Kernel.open'
	from -e:1:in '<main>'
```

**Docs Changes**:
N/A

**Release Note**:
N/A

Signed-off-by: Shizuo Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daipom daipom daipom approved these changes

Assignees

No one assigned

Labels

backport to v1.16 We will backport this fix to the LTS branch backport to v1.19 We will backport this fix to the LTS branch backported "backport to LTS" is done CI Test/CI issues

Projects

None yet

Milestone

v1.20.0

Development

Successfully merging this pull request may close these issues.

CI: Failed test_with_ruby_keyword(ConfigDSLTest) with Ruby HEAD

2 participants

@Watson1978 @daipom