Backport(v1.19): YAML config: Supports parsing array format (#5126) #5139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
force-pushed
the
backport-to-1.19/pr5126
branch
from
fd51f99 to
5c5bfef
Compare
<!-- Thank you for contributing to Fluentd! Your commits need to follow DCO: https://probot.github.io/apps/dco/ And please provide the following information to help us make the most of your pull request: --> **Which issue(s) this PR fixes**: None. **What this PR does / why we need it**: Supports parsing array of basic data types when analyzing YAML configuration files. The current behavior of Fluentd: * Support YAML Array format for `$args` only. * Other Array options must be specified in a comma-separated format. * `retryable_response_codes: 503, 504` * If there’s only a single value, it must be specified as String or with the trailing comma. * `retryable_response_codes: "503"` * `retryable_response_codes: 503,` This supports YAML Array format for all options. ``` retryable_response_codes: - 503 ``` ``` retryable_response_codes: [503] ``` Note: This PR doesn't address the issue where setting an Int directly to an Array option causes ConfigError: `retryable_response_codes: 503` (The `C` case in #5126 (comment)) It could be a different issue. **Docs Changes**: Not Need **Release Note**: Same as the title. --------- Signed-off-by: Hear_Y <[email protected]> Signed-off-by: Daijiro Fukuda <[email protected]> Co-authored-by: Daijiro Fukuda <[email protected]> Signed-off-by: Shizuo Fujita <[email protected]>
Watson1978
force-pushed
the
backport-to-1.19/pr5126
branch
from
5c5bfef to
45f0ffa
Compare
daipom
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #5126
Which issue(s) this PR fixes:
None.
What this PR does / why we need it:
Supports parsing array of basic data types when analyzing YAML configuration files.
The current behavior of Fluentd:
$argsonly.retryable_response_codes: 503, 504retryable_response_codes: "503"retryable_response_codes: 503,This supports YAML Array format for all options.
Note: This PR doesn't address the issue where setting an Int directly to an Array option causes ConfigError:
retryable_response_codes: 503(TheCcase in#5126 (comment)) It could be a different issue.
Docs Changes: Not Need
Release Note: Same as the title.