Backport(v1.16): test_plugin_helper: fix test class name (#5064) #5083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
approved these changes
Sep 11, 2025
daipom
force-pushed
the
barkport-pr5064
branch
from
7f47c93 to
8851aaf
Compare
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: `test_config.rb` and `test_plugin_helper.rb` has same class name. https://github.com/fluent/fluentd/blob/338050012279f401af41c95049d82cb98b2a370b/test/test_config.rb#L8 https://github.com/fluent/fluentd/blob/338050012279f401af41c95049d82cb98b2a370b/test/test_plugin_helper.rb#L5 The test class name should be unique. **Docs Changes**: Not needed. **Release Note**: CI improvements. Signed-off-by: Shizuo Fujita <[email protected]> Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
force-pushed
the
barkport-pr5064
branch
from
8851aaf to
c2f1f1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
test_config.rbandtest_plugin_helper.rbhas same class name.fluentd/test/test_config.rb
Line 8 in 3380500
fluentd/test/test_plugin_helper.rb
Line 5 in 3380500
The test class name should be unique.
Docs Changes:
Not needed.
Release Note:
CI improvements.