Skip to content

test_plugin_helper: fix test class name #5064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daipom merged 1 commit into from
Aug 21, 2025
Merged

test_plugin_helper: fix test class name #5064

daipom merged 1 commit into from
Aug 21, 2025

Conversation

@Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Aug 20, 2025 •
edited by daipom
Loading

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:

test_config.rb and test_plugin_helper.rb has same class name.

fluentd/test/test_config.rb

Line 8 in 3380500

class ConfigTest < Test::Unit::TestCase

fluentd/test/test_plugin_helper.rb

Line 5 in 3380500

class ConfigTest < Test::Unit::TestCase

The test class name should be unique.

Docs Changes:
Not needed.

Release Note:
CI improvements.

@Watson1978 Watson1978 requested review from daipom and kenhys August 20, 2025 09:37
@Watson1978
Copy link
Contributor Author

Watson1978 commented Aug 20, 2025

Seems ConfigTest class appears to hold test cases for test_config.rb and test_plugin_helper.rb in one place.

bundle exec ruby -w -Ilib -Itest C:/Ruby33-x64/lib/ruby/gems/3.3.0/gems/rake-13.3.0/lib/rake/rake_test_loader.rb test/test_config.rb test/test_plugin_helper.rb -v
C:/Ruby33-x64/lib/ruby/gems/3.3.0/gems/serverengine-2.4.0/lib/serverengine/socket_manager_win.rb:141: warning: assigned but unused variable - type
C:/Ruby33-x64/lib/ruby/gems/3.3.0/gems/protocol-http-0.52.0/lib/protocol/http/header/accept.rb:84: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument
C:/src/fluentd/lib/fluent/plugin_helper.rb:46: warning: method redefined; discarding old inherited
C:/src/fluentd/lib/fluent/plugin_helper.rb:46: warning: previous definition of inherited was here
Loaded suite C:/Ruby33-x64/lib/ruby/gems/3.3.0/gems/rake-13.3.0/lib/rake/rake_test_loader
Started
ConfigTest: 
  test_check_not_fetchd:																			.: (0.001557)
  test_include:																					.: (0.006763)
  .build: 
    test: read config:																				.: (0.001474)
    test: read config with additional_config:																	.: (0.000867)
    test: read config with encoding:																		.: (0.005180)
  Fluent::Plugin::Base.helpers method works as shortcut to include helper modules: 
    test: plugin can 2 or more helpers at once:																	.: (0.000450)
    test: plugin can include helper child_process:																.: (0.000191)
    test: plugin can include helper event_emitter:																.: (0.000156)
    test: plugin can include helper event_loop:																	.: (0.000130)
    test: plugin can include helper thread:																	.: (0.000194)
    test: plugin can include helper timer:																	.: (0.000120)
  yaml config: 
    test_check_not_fetchd:																			.: (0.001134)
    test_included:																				.: (0.001920)
    test_included_glob:

@daipom daipom added this to the v1.20.0 milestone Aug 21, 2025
@daipom daipom added backport to v1.16 We will backport this fix to the LTS branch CI Test/CI issues labels Aug 21, 2025
daipom
daipom approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daipom daipom merged commit b185aa4 into fluent:master Aug 21, 2025
17 checks passed
@Watson1978 Watson1978 deleted the fix-test-class-name branch August 21, 2025 02:47
daipom pushed a commit to daipom/fluentd that referenced this pull request Sep 10, 2025
@Watson1978 @daipom
test_plugin_helper: fix test class name (fluent#5064)
7f47c93 
**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:

`test_config.rb` and `test_plugin_helper.rb` has same class name.

https://github.com/fluent/fluentd/blob/338050012279f401af41c95049d82cb98b2a370b/test/test_config.rb#L8

https://github.com/fluent/fluentd/blob/338050012279f401af41c95049d82cb98b2a370b/test/test_plugin_helper.rb#L5

The test class name should be unique.

**Docs Changes**:
Not needed.

**Release Note**:
CI improvements.

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom mentioned this pull request Sep 10, 2025
Merged
daipom pushed a commit to daipom/fluentd that referenced this pull request Sep 11, 2025
@Watson1978 @daipom
test_plugin_helper: fix test class name (fluent#5064)
8851aaf 
**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:

`test_config.rb` and `test_plugin_helper.rb` has same class name.

https://github.com/fluent/fluentd/blob/338050012279f401af41c95049d82cb98b2a370b/test/test_config.rb#L8

https://github.com/fluent/fluentd/blob/338050012279f401af41c95049d82cb98b2a370b/test/test_plugin_helper.rb#L5

The test class name should be unique.

**Docs Changes**:
Not needed.

**Release Note**:
CI improvements.

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
daipom pushed a commit to daipom/fluentd that referenced this pull request Sep 11, 2025
@Watson1978 @daipom
test_plugin_helper: fix test class name (fluent#5064)
c2f1f1d 
**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:

`test_config.rb` and `test_plugin_helper.rb` has same class name.

https://github.com/fluent/fluentd/blob/338050012279f401af41c95049d82cb98b2a370b/test/test_config.rb#L8

https://github.com/fluent/fluentd/blob/338050012279f401af41c95049d82cb98b2a370b/test/test_plugin_helper.rb#L5

The test class name should be unique.

**Docs Changes**:
Not needed.

**Release Note**:
CI improvements.

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
daipom added a commit that referenced this pull request Sep 11, 2025
@daipom @Watson1978
Backport(v1.16): test_plugin_helper: fix test class name (#5064) (#5083)
269a0e0 
**Which issue(s) this PR fixes**:
* Backport #5064

**What this PR does / why we need it**:

`test_config.rb` and `test_plugin_helper.rb` has same class name.


https://github.com/fluent/fluentd/blob/338050012279f401af41c95049d82cb98b2a370b/test/test_config.rb#L8


https://github.com/fluent/fluentd/blob/338050012279f401af41c95049d82cb98b2a370b/test/test_plugin_helper.rb#L5

The test class name should be unique.

**Docs Changes**:
Not needed.

**Release Note**:
CI improvements.

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Shizuo Fujita <[email protected]>
@daipom daipom added the backported "backport to LTS" is done label Sep 11, 2025
@daipom daipom modified the milestones: v1.20.0, v1.19.1 Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daipom daipom daipom approved these changes

@kenhys kenhys Awaiting requested review from kenhys

Assignees

No one assigned

Labels

backport to v1.16 We will backport this fix to the LTS branch backported "backport to LTS" is done CI Test/CI issues

Projects

None yet

Milestone

v1.19.1

Development

Successfully merging this pull request may close these issues.

2 participants

@Watson1978 @daipom