Skip to content

Conversation

@Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Aug 20, 2025

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:
Very rarely, tests may take a long time to run, but it is difficult to determine which tests took a long time.

At test-unit v3.6.3, --report-slow-tests option was introduced to show the top 5 slow tests.

https://github.com/test-unit/test-unit/blob/d641c29d4068d407808c42b15c6dcdf9c2f2b439/doc/text/news.md?plain=1#L137-L140

I think it might be useful.

Related to #5041

Docs Changes:
Not needed.

Release Note:
CI improvements.

@Watson1978
Copy link
Contributor Author

Watson1978 commented Aug 20, 2025

Output example:

...

Finished in 2279.5396206 seconds.
-------------------------------------------------------------------------------
Top 5 slow tests
test: enabled typecasting of values with enable_ruby yes(RecordTransformerFilterTest::test placeholders): 771.985545                 
--location D:/a/fluentd/fluentd/test/plugin/test_filter_record_transformer.rb:461
test: retry_timeout and retry_max_times will be ignored if retry_forever is true for periodical retries(BufferedOutputRetryTest::buffered output configured as retry_forever): 15.159959                                                                                       
--location D:/a/fluentd/fluentd/test/plugin/test_output_as_buffered_retries.rb:841
test: retry_timeout and retry_max_times will be ignored if retry_forever is true for exponential backoff(BufferedOutputRetryTest::buffered output configured as retry_forever): 15.157596                                                                                        
--location D:/a/fluentd/fluentd/test/plugin/test_output_as_buffered_retries.rb:770
test: output plugin give retries up by retry_timeout, and clear queue in buffer(BufferedOutputRetryTest::buffered output for retries with exponential backoff): 12.151939                                                                        
--location D:/a/fluentd/fluentd/test/plugin/test_output_as_buffered_retries.rb:247
test: exponential backoff interval will be initialized when switched to secondary(BufferedOutputSecondaryTest::secondary plugin feature for buffered output with exponential backoff): 11.048311                                                                                               
--location D:/a/fluentd/fluentd/test/plugin/test_output_as_buffered_secondary.rb:789
-------------------------------------------------------------------------------
4122 tests, 13724 assertions, 0 failures, 0 errors, 0 pendings, 89 omissions, 0 notifications
100% passed
-------------------------------------------------------------------------------
1.81 tests/s, 6.02 assertions/s
test_file_util.rb for non-root user env. Disable this test on root environment

https://github.com/Watson1978/fluentd/actions/runs/17091143542/job/48465000036

Looks like RecordTransformerFilterTest::test placeholders test still takes a long time sometimes on Windows.

@Watson1978 Watson1978 requested review from daipom and kenhys August 20, 2025 08:35
@Watson1978
Copy link
Contributor Author

Hmmm, I think #5041 is not fixed yet.

test: invalid record for placeholders(RecordTransformerFilterTest::test error record): 5206.360391
--location D:/a/fluentd/fluentd/test/plugin/test_filter_record_transformer.rb:563

https://github.com/fluent/fluentd/actions/runs/17092348824/job/48468713270?pr=5063

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daipom daipom modified the milestones: v1.19.1, v1.20.0 Aug 21, 2025
@daipom daipom added backport to v1.16 We will backport this fix to the LTS branch CI Test/CI issues labels Aug 21, 2025
@daipom daipom merged commit 245b1be into fluent:master Aug 21, 2025
17 checks passed
@Watson1978 Watson1978 deleted the report_slow_tests branch August 21, 2025 02:16
daipom pushed a commit to daipom/fluentd that referenced this pull request Sep 10, 2025
**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:
Very rarely, tests may take a long time to run, but it is difficult to
determine which tests took a long time.

At [test-unit](https://github.com/test-unit/test-unit) v3.6.3,
`--report-slow-tests` option was introduced to show the top 5 slow
tests.

https://github.com/test-unit/test-unit/blob/d641c29d4068d407808c42b15c6dcdf9c2f2b439/doc/text/news.md?plain=1#L137-L140

I think it might be useful.

Related to fluent#5041

**Docs Changes**:
Not needed.

**Release Note**:
CI improvements.

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
daipom pushed a commit to daipom/fluentd that referenced this pull request Sep 11, 2025
**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:
Very rarely, tests may take a long time to run, but it is difficult to
determine which tests took a long time.

At [test-unit](https://github.com/test-unit/test-unit) v3.6.3,
`--report-slow-tests` option was introduced to show the top 5 slow
tests.

https://github.com/test-unit/test-unit/blob/d641c29d4068d407808c42b15c6dcdf9c2f2b439/doc/text/news.md?plain=1#L137-L140

I think it might be useful.

Related to fluent#5041

**Docs Changes**:
Not needed.

**Release Note**:
CI improvements.

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
daipom pushed a commit to daipom/fluentd that referenced this pull request Sep 11, 2025
**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:
Very rarely, tests may take a long time to run, but it is difficult to
determine which tests took a long time.

At [test-unit](https://github.com/test-unit/test-unit) v3.6.3,
`--report-slow-tests` option was introduced to show the top 5 slow
tests.

https://github.com/test-unit/test-unit/blob/d641c29d4068d407808c42b15c6dcdf9c2f2b439/doc/text/news.md?plain=1#L137-L140

I think it might be useful.

Related to fluent#5041

**Docs Changes**:
Not needed.

**Release Note**:
CI improvements.

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom modified the milestones: v1.20.0, v1.19.1 Sep 11, 2025
daipom added a commit that referenced this pull request Sep 11, 2025
**Which issue(s) this PR fixes**:
* Backport #5063

**What this PR does / why we need it**:
Very rarely, tests may take a long time to run, but it is difficult to
determine which tests took a long time.

At [test-unit](https://github.com/test-unit/test-unit) v3.6.3,
`--report-slow-tests` option was introduced to show the top 5 slow
tests.


https://github.com/test-unit/test-unit/blob/d641c29d4068d407808c42b15c6dcdf9c2f2b439/doc/text/news.md?plain=1#L137-L140

I think it might be useful.

Related to #5041

**Docs Changes**:
Not needed.

**Release Note**:
CI improvements.

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Shizuo Fujita <[email protected]>
@daipom daipom added the backported "backport to LTS" is done label Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport to v1.16 We will backport this fix to the LTS branch backported "backport to LTS" is done CI Test/CI issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants