Skip to content

Conversation

@kenhys
Copy link
Contributor

@kenhys kenhys commented Apr 26, 2025

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:

It will reduce rubocop warnings with the following configuration:

  Layout/TrailingWhitespace:
    Enabled: true

This is just cosmetic change. It will not break tests.

Docs Changes:

N/A

Release Note:

N/A

It will reduce rubocop warnings with the following:

  Layout/TrailingWhitespace:
    Enabled: true

This is just cosmetic change. It will not break tests.

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys changed the title test: fix trailing-whitespace rubocop: fix trailing-whitespace Apr 26, 2025
Copy link
Contributor

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@kenhys kenhys merged commit 98a4e32 into fluent:master Apr 27, 2025
10 checks passed
@kenhys kenhys deleted the trailing-whitespace branch April 27, 2025 06:46
@Watson1978 Watson1978 added the backport to v1.16 We will backport this fix to the LTS branch label Apr 27, 2025
@daipom
Copy link
Contributor

daipom commented Apr 28, 2025

Do we backport this to LTS?

@Watson1978
Copy link
Contributor

If we want to reduce the possibility of conflicts in the future,
I think it would be better to backport.

@daipom daipom added this to the v1.19.0 milestone Apr 30, 2025
kenhys added a commit to kenhys/fluentd that referenced this pull request Apr 30, 2025
**Which issue(s) this PR fixes**:
Backport: fluent#4928
Fixes #

**What this PR does / why we need it**:

It will reduce rubocop warnings with the following configuration:

```yml
  Layout/TrailingWhitespace:
    Enabled: true
```

This is just cosmetic change. It will not break tests.

NOTE: the following files are additionally detected only in v1.16 branch
* lib/fluent/plugin/in_http.rb
* lib/fluent/plugin/in_tail.rb
* test/plugin/test_in_http.rb

**Docs Changes**:

N/A

**Release Note**:

N/A

Signed-off-by: Kentaro Hayashi <[email protected]>
daipom pushed a commit that referenced this pull request Apr 30, 2025
**Which issue(s) this PR fixes**:
Backport: #4928
Fixes #

**What this PR does / why we need it**:

It will reduce rubocop warnings with the following configuration:

```yml
  Layout/TrailingWhitespace:
    Enabled: true
```

This is just cosmetic change. It will not break tests.

NOTE: the following files are additionally detected only in v1.16 branch
* lib/fluent/plugin/in_http.rb
* lib/fluent/plugin/in_tail.rb
* test/plugin/test_in_http.rb

**Docs Changes**:

N/A

**Release Note**:

N/A

Signed-off-by: Kentaro Hayashi <[email protected]>
@daipom daipom added the backported "backport to LTS" is done label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport to v1.16 We will backport this fix to the LTS branch backported "backport to LTS" is done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants