Skip to content

Conversation

@kenhys
Copy link
Contributor

@kenhys kenhys commented Apr 23, 2025

Which issue(s) this PR fixes:

Fixes #

What this PR does / why we need it:

In the previous versions, it is hard to identify
the separator of elements.
Added attr: and elements: prefix for properties and mark it <...>.

Before:

  name:ROOT, arg:, {}, [name:system, arg:,
  {"config_include_dir"=>"..."}, [], name:source, arg:,
  {"@type"=>"forward"}, [], name:source, arg:, {"@type"=>"tcp"}, []]

After:

  <name:ROOT, arg:, attrs:{}, elements:[<name:system, arg:,
  attrs:{"config_include_dir"=>"..."}, elements:[]>, <name:source,
  arg:, attrs:{"@type"=>"forward"}, []>, <name:source, arg:,
  atrrs:{"@type"=>"tcp"}, elements:[]>]

Docs Changes:

N/A

Release Note:

@kenhys kenhys force-pushed the developer-friendly-element branch from f3f8e0e to 9b0e2f9 Compare April 23, 2025 04:58
@kenhys kenhys added this to the v1.19.0 milestone Apr 23, 2025
In the previous versions, it is hard to identify
the separator of elements.
Added attr: and elements: prefix for properties and mark it <...>.

Before:

  name:ROOT, arg:, {}, [name:system, arg:,
  {"config_include_dir"=>"..."}, [], name:source, arg:,
  {"@type"=>"forward"}, [], name:source, arg:, {"@type"=>"tcp"}, []]

After:

  <name:ROOT, arg:, attrs:{}, elements:[<name:system, arg:,
  attrs:{"config_include_dir"=>"..."}, elements:[]>, <name:source,
  arg:, attrs:{"@type"=>"forward"}, []>, <name:source, arg:,
  atrrs:{"@type"=>"tcp"}, elements:[]>]

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys force-pushed the developer-friendly-element branch from 9b0e2f9 to 15ea045 Compare April 23, 2025 05:00
@kenhys kenhys marked this pull request as ready for review April 23, 2025 05:01
@kenhys kenhys requested review from Watson1978 and daipom April 23, 2025 05:37
Co-authored-by: Daijiro Fukuda <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys force-pushed the developer-friendly-element branch from d2a6d3c to 5f5ef43 Compare April 25, 2025 07:33
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daipom daipom merged commit 17afe66 into fluent:master Apr 25, 2025
10 checks passed
@kenhys kenhys deleted the developer-friendly-element branch April 25, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants