v1_parser: use URI#open instead of URI.open #4854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
added
the
backport to v1.16
Watson1978
force-pushed
the
codeql/v1_parser
branch
3 times, most recently
from
04a12fb to
0254d7e
Compare
daipom
reviewed
Mar 6, 2025
Contributor
daipom
left a comment
daipom
left a comment
There was a problem hiding this comment.
Thanks.
It appears to me that v1parser can recognize Windows absolute paths (C:/foo).
Can't we just use u.open?
Contributor
Author
|
Thanks. Indeed, seems it recognize Windows path. |
Signed-off-by: Shizuo Fujita <[email protected]>
Watson1978
force-pushed
the
codeql/v1_parser
branch
from
0254d7e to
d6aa891
Compare
kenhys
pushed a commit
to kenhys/fluentd
that referenced
this pull request
Apr 23, 2025
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: By [CodeQL documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/), it is safer to avoid using `URI.open`. This is similar with fluent#4848 **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <[email protected]> Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
pushed a commit
to kenhys/fluentd
that referenced
this pull request
Apr 23, 2025
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: By [CodeQL documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/), it is safer to avoid using `URI.open`. This is similar with fluent#4848 **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <[email protected]> Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
pushed a commit
to kenhys/fluentd
that referenced
this pull request
Apr 23, 2025
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: By [CodeQL documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/), it is safer to avoid using `URI.open`. This is similar with fluent#4848 **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <[email protected]> Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
pushed a commit
to kenhys/fluentd
that referenced
this pull request
Apr 23, 2025
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: By [CodeQL documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/), it is safer to avoid using `URI.open`. This is similar with fluent#4848 **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <[email protected]> Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
pushed a commit
to kenhys/fluentd
that referenced
this pull request
Apr 23, 2025
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: By [CodeQL documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/), it is safer to avoid using `URI.open`. This is similar with fluent#4848 **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <[email protected]> Signed-off-by: Kentaro Hayashi <[email protected]>
daipom
pushed a commit
that referenced
this pull request
Apr 24, 2025
…4921) **Which issue(s) this PR fixes**: Backport #4854 Fixes # **What this PR does / why we need it**: By [CodeQL documentation](https://codeql.github.com/codeql-query-help/ruby/rb-non-constant-kernel-open/), it is safer to avoid using `URI.open`. This is similar with #4848 **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <[email protected]> Signed-off-by: Kentaro Hayashi <[email protected]> Co-authored-by: Shizuo Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
By CodeQL documentation, it is safer to avoid using
URI.open.This is a false positive, so there is no impact on Fluentd.
(Because URI.parse checks the uri in advance.)
This is similar with #4848
Docs Changes:
Release Note: