-
Notifications
You must be signed in to change notification settings - Fork 1.4k
memory_chunk: clear internal memory use in buffer string #4845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
commented
Mar 7, 2025
Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
9a6db75 to
1f97eec
Compare
… value directly Signed-off-by: Shizuo Fujita <[email protected]>
1f97eec to
6a86630
Compare
daipom
reviewed
Mar 11, 2025
Contributor
daipom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement!
Basically looks good to me!
I have commented on some points for the test code.
It could be simpler.
Please check them.
Signed-off-by: Shizuo Fujita <[email protected]>
Contributor
|
Thanks! Waiting CI... |
daipom
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #1657
What this PR does / why we need it:
Seems that a full GC have to run in order to collect the wasted String object in
@chunk.However, full GC is not performed frequently.
This patch purges internal memory in wasted String object immediately.
Here is memory usage retrieved by
ObjectSpace.memsize_of_all.Note
Ruby has various optimization, such as reusing freed heap areas by pooling them.
For this reason, it may not be reflected in the process's memory usage immediately even if it clear the object.
Reproduce
Docs Changes:
Not needed.
Release Note:
buf_memory: improve memory performance