chumask: fix issue where it only works with standalone worker #4836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix fluent#3671 (88a7260) After fluent#3671, the value of `chumask` passed to ServerEngine was always `nil`. The `chumask` value was being used only when standalone. It appears to be unintentional. This fixes it. * By default, `0` as `chumask` is passed to ServerEngine. * If specifying `--umask` option, that value is passed. * This `chumask` value is applied when using `daemonize`. * When not using `daemonize`, the value is not used. * This is the specification of ServerEngine. Specification change: (Just undo the specification that fluent#3671 unintentionally changed.) * This changes the default `umask` when using `daemonize`. * fluent-package (RPM/DEB), for example. * Before: system default (`nil` for ServerEngine) * After: `0` Signed-off-by: Daijiro Fukuda <[email protected]>
Contributor
Author
|
It would be necessary for us to solve this issue before making the following enhancement: |
This was referenced Feb 21, 2025
ashie
approved these changes
Feb 26, 2025
daipom
deleted the
chumask-fix-issue-where-it-only-works-with-standalone-worker
branch
Contributor
Author
|
Thanks for your review! |
Contributor
|
MEMO: will not backport to v1.16 because behavior is changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
Fix #3671 (88a7260)
After #3671, the value of
chumaskpassed to ServerEngine was alwaysnil.The
chumaskvalue was being used only when standalone. It appears to be unintentional.This fixes it.
0aschumaskis passed to ServerEngine.--umaskoption, that value is passed.chumaskvalue is applied when usingdaemonize.daemonize, the value is not used.Specification change:
(Just undo the specification that #3671 unintentionally changed.)
umaskwhen usingdaemonize.nilfor ServerEngine)0Docs Changes:
Not needed.
(There is not enough information on https://docs.fluentd.org/deployment/command-line-option. It would be good to add more information.)
Release Note:
umaskwas not set to0when using--daemon(td-agent, fluent-package) since v1.14.6.--umaskcommand line option: Fixed so that it is applied when Fluentd runs with--daemon(fluent-package) as well as when Fluentd runs with--no-supervisor.