Skip to content

Conversation

@daipom
Copy link
Contributor

@daipom daipom commented Feb 4, 2025

Which issue(s) this PR fixes:
None.

What this PR does / why we need it:
Fix unstable test.

Error: test: creates a udp server to read and write data using IPv6(ServerPluginHelperTest::#server_create_udp): Errno::EADDRINUSE: Address already in use - bind(2) for "::1" port 8859
/home/runner/work/fluentd/fluentd/test/plugin_helper/test_server.rb:697:in 'UDPSocket#bind'
/home/runner/work/fluentd/fluentd/test/plugin_helper/test_server.rb:697:in 'block (3 levels) in <class:ServerPluginHelperTest>'
<internal:numeric>:257:in 'Integer#times'
/home/runner/work/fluentd/fluentd/test/plugin_helper/test_server.rb:694:in 'block (2 levels) in <class:ServerPluginHelperTest>'

Docs Changes:
Not needed.

Release Note:
The same as the title.

Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom requested review from Watson1978 and kenhys February 4, 2025 05:32
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys
Copy link
Contributor

kenhys commented Feb 4, 2025

by default, 0.0.0.0 was used, so it is not appropriate in this context.

@kenhys kenhys merged commit d35f5a1 into fluent:master Feb 4, 2025
10 checks passed
@daipom daipom deleted the ci-fix-unstable-test branch February 4, 2025 08:15
@daipom daipom added this to the v1.19.0 milestone Feb 4, 2025
@daipom daipom added the backport to v1.16 We will backport this fix to the LTS branch label Feb 4, 2025
daipom added a commit that referenced this pull request Feb 4, 2025
**Which issue(s) this PR fixes**:
None.

**What this PR does / why we need it**:
Fix unstable test.

```
Error: test: creates a udp server to read and write data using IPv6(ServerPluginHelperTest::#server_create_udp): Errno::EADDRINUSE: Address already in use - bind(2) for "::1" port 8859
/home/runner/work/fluentd/fluentd/test/plugin_helper/test_server.rb:697:in 'UDPSocket#bind'
/home/runner/work/fluentd/fluentd/test/plugin_helper/test_server.rb:697:in 'block (3 levels) in <class:ServerPluginHelperTest>'
<internal:numeric>:257:in 'Integer#times'
/home/runner/work/fluentd/fluentd/test/plugin_helper/test_server.rb:694:in 'block (2 levels) in <class:ServerPluginHelperTest>'
```

**Docs Changes**:
Not needed.

**Release Note**:
The same as the title.

Signed-off-by: Daijiro Fukuda <[email protected]>
kenhys pushed a commit that referenced this pull request Feb 4, 2025
**Which issue(s) this PR fixes**:
* Backport #4820

**What this PR does / why we need it**:
Fix unstable test.

```
Error: test: creates a udp server to read and write data using IPv6(ServerPluginHelperTest::#server_create_udp): Errno::EADDRINUSE: Address already in use - bind(2) for "::1" port 8859
/home/runner/work/fluentd/fluentd/test/plugin_helper/test_server.rb:697:in 'UDPSocket#bind'
/home/runner/work/fluentd/fluentd/test/plugin_helper/test_server.rb:697:in 'block (3 levels) in <class:ServerPluginHelperTest>'
<internal:numeric>:257:in 'Integer#times'
/home/runner/work/fluentd/fluentd/test/plugin_helper/test_server.rb:694:in 'block (2 levels) in <class:ServerPluginHelperTest>'
```

**Docs Changes**:
Not needed.

**Release Note**:
The same as the title.

Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom added the backported "backport to LTS" is done label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport to v1.16 We will backport this fix to the LTS branch backported "backport to LTS" is done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants