in_http improvements #473
Merged
in_http improvements #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'add_remote_ip' configuration parameter allows the output filter to include the source IP address in a field called 'REMOTE_ADDR'. It can be activated into the source as follows: <source> type http port 9880 add_remote_ip </source> Signed-off-by: Eduardo Silva <[email protected]>
…t#426). This patch enable a partial and optional CORS support. For clients that want to talk directly to this source, it allows to set a white list of Cross Origin clients through the validation of the HTTP Origin header. Usage: <source> type http port 9880 cors_allow_origins http://example.com, http://www.treasuredata.com </source> The new configuration key 'cors_allow_origins', allows to specify a white list of domains, they must be separated by coma. For those request that do not pass the CORS filter, the service will respond with a '403 Forbidden' HTTP status code and close the connection. Note: the CORS validation is based on the HTTP request headers, for hence is NOT secure. Signed-off-by: Eduardo Silva <[email protected]>
lib/fluent/plugin/in_http.rb
Outdated
Member
There was a problem hiding this comment.
We have array type since v0.10.46 so using array is better than 'a,b,c' string style.
Signed-off-by: Eduardo Silva <[email protected]>
Member
Author
|
thanks for the feedback. I have updated the branch with the suggested changes:
|
This patch makes the cors_allow_origins configuration key to store a JSON array, it can be used as follows: <source> type http port 9880 cors_allow_origins ["http://example.com", "http://www.treasuredata.com"] </source> Signed-off-by: Eduardo Silva <[email protected]>
edsiper
force-pushed
the
HTTP_improvements
branch
from
1aba01e to
a839c20
Compare
Member
|
LGTM 👍 |
Member
|
I just merged this PR. If there are some feedbacks from users, we will update the code. |
repeatedly
added a commit
that referenced
this pull request
Nov 24, 2014
in_http improvements Conflicts: lib/fluent/plugin/in_http.rb
Member
|
cherry-picked to v0.10 branch (27b25b2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the following patches add support for two new configuration directives: