Skip to content

Conversation

@Watson1978
Copy link
Contributor

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:
Often I forget to Signed-off and push new commit again. I would like the github action related to the PR to be automatically cancelled at that time. I want the test to run on the newly pushed commit immediately.

Ref. https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs

Docs Changes:

Release Note:

Often I forget to Signed-off and push new commit again.
I would like the github action related to the PR to be automatically cancelled at that time.
I want the test to run on the newly pushed commit immediately.

Ref. https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs

Signed-off-by: Shizuo Fujita <[email protected]>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
It would reduce unnecessary test run.

@daipom daipom merged commit 078b8d9 into fluent:master Oct 29, 2024
@Watson1978 Watson1978 deleted the cancel-in-progress branch October 29, 2024 09:37
@daipom daipom added the backport to v1.16 We will backport this fix to the LTS branch label Nov 29, 2024
@daipom daipom added the CI Test/CI issues label Jan 28, 2025
@daipom daipom added this to the v1.18.0 milestone Jan 28, 2025
@kenhys
Copy link
Contributor

kenhys commented Apr 23, 2025

Not backported yet.

kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 25, 2025
Often I forget to Signed-off and push new commit again.
I would like the github action related to the PR to be automatically cancelled at that time.
I want the test to run on the newly pushed commit immediately.

Ref. https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 25, 2025
Often I forget to Signed-off and push new commit again.
I would like the github action related to the PR to be automatically cancelled at that time.
I want the test to run on the newly pushed commit immediately.

Ref. https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
daipom pushed a commit that referenced this pull request Apr 25, 2025
**Which issue(s) this PR fixes**: 

Backport: #4689 
Fixes #

**What this PR does / why we need it**: 

Often I forget to Signed-off and push new commit again. I would like the
github action related to the PR to be automatically cancelled at that
time. I want the test to run on the newly pushed commit immediately.

Ref.
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
Co-authored-by: Watson <[email protected]>
@daipom daipom added the backported "backport to LTS" is done label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport to v1.16 We will backport this fix to the LTS branch backported "backport to LTS" is done CI Test/CI issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants