-
Notifications
You must be signed in to change notification settings - Fork 1.4k
CI: use latest rubygems #4681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
CI: use latest rubygems #4681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shizuo Fujita <[email protected]>
daipom
approved these changes
Oct 22, 2024
Contributor
daipom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Watson1978
added a commit
to Watson1978/fluentd
that referenced
this pull request
Dec 19, 2024
This reverts commit a5cccf5.
kenhys
added a commit
to kenhys/fluentd
that referenced
this pull request
Dec 26, 2024
This reverts commit a5cccf5. This fix is only required for Ruby 3.0. As required ruby version is bumped up to 3.2, no need to apply anymore. Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
added a commit
to kenhys/fluentd
that referenced
this pull request
Dec 26, 2024
This reverts commit a5cccf5. This fix is only required for Ruby 3.0. As required ruby version is bumped up to 3.2, no need to apply anymore. Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
added a commit
to kenhys/fluentd
that referenced
this pull request
Dec 26, 2024
This reverts commit a5cccf5. This fix is only required for Ruby 3.0. As required ruby version is bumped up to 3.2, no need to apply anymore. Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
added a commit
that referenced
this pull request
Jan 29, 2025
**Which issue(s) this PR fixes**: Backport #4750 **What this PR does / why we need it**: It seems that it fixes failure with Ruby 3.1 on windows. ``` undefined method `ignored?' for #<Gem::Specification:0x000001dccaf43168 ``` NOTE: Initially introduced by #4681, then reverted in #4746. Thus, it's a side-effect of #4760. **Docs Changes**: N/A **Release Note**: N/A Signed-off-by: Kentaro Hayashi <[email protected]>
daipom
pushed a commit
that referenced
this pull request
Jan 29, 2025
…#4750) (#4803) **Which issue(s) this PR fixes**: Backport #4750 **What this PR does / why we need it**: It seems that it fixes failure with Ruby 3.1 on windows. ``` undefined method `ignored?' for #<Gem::Specification:0x000001dccaf43168 ``` NOTE: Initially introduced by #4681, then reverted in #4746. Thus, it's a side-effect of #4746. **Docs Changes**: N/A **Release Note**: N/A Signed-off-by: Kentaro Hayashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #4678
What this PR does / why we need it:
The latest bundler appears to depend on the recent RubyGems version.
Make sure to install the latest rubygem to run CI successfully.
Docs Changes:
Release Note: