Skip to content

Conversation

@Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Oct 22, 2024

Which issue(s) this PR fixes:
Fixes #4678

What this PR does / why we need it:
The latest bundler appears to depend on the recent RubyGems version.
Make sure to install the latest rubygem to run CI successfully.

Docs Changes:

Release Note:

Signed-off-by: Shizuo Fujita <[email protected]>
@Watson1978 Watson1978 marked this pull request as ready for review October 22, 2024 00:45
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom merged commit a5cccf5 into fluent:master Oct 22, 2024
@Watson1978 Watson1978 deleted the ci/use-latest-rubygems branch October 22, 2024 01:33
Watson1978 added a commit to Watson1978/fluentd that referenced this pull request Dec 19, 2024
kenhys added a commit to kenhys/fluentd that referenced this pull request Dec 26, 2024
This reverts commit a5cccf5.

This fix is only required for Ruby 3.0.
As required ruby version is bumped up to 3.2, no need to apply anymore.

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluentd that referenced this pull request Dec 26, 2024
This reverts commit a5cccf5.

This fix is only required for Ruby 3.0.
As required ruby version is bumped up to 3.2, no need to apply anymore.

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluentd that referenced this pull request Dec 26, 2024
This reverts commit a5cccf5.

This fix is only required for Ruby 3.0.
As required ruby version is bumped up to 3.2, no need to apply anymore.

Signed-off-by: Kentaro Hayashi <[email protected]>
@daipom daipom added this to the v1.18.0 milestone Jan 28, 2025
@daipom daipom added the CI Test/CI issues label Jan 28, 2025
kenhys added a commit that referenced this pull request Jan 29, 2025
**Which issue(s) this PR fixes**:

Backport #4750

**What this PR does / why we need it**:

It seems that it fixes failure with Ruby 3.1 on windows.

```
   undefined method `ignored?' for #<Gem::Specification:0x000001dccaf43168
```

NOTE: Initially introduced by #4681, then reverted in #4746.
Thus, it's a side-effect of #4760.

**Docs Changes**:

N/A

**Release Note**:

N/A

Signed-off-by: Kentaro Hayashi <[email protected]>
daipom pushed a commit that referenced this pull request Jan 29, 2025
…#4750) (#4803)

**Which issue(s) this PR fixes**:

Backport #4750

**What this PR does / why we need it**:

It seems that it fixes failure with Ruby 3.1 on windows.

```
   undefined method `ignored?' for #<Gem::Specification:0x000001dccaf43168
```

NOTE: Initially introduced by #4681, then reverted in #4746. Thus, it's
a side-effect of #4746.

**Docs Changes**:

N/A

**Release Note**:

N/A

Signed-off-by: Kentaro Hayashi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Test/CI issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Fails ”test: multiple values are set to RUBYOPT(TestFluentdCommand::configured to run 2 workers)" test on Windows

2 participants