Skip to content

Conversation

@Watson1978
Copy link
Contributor

Which issue(s) this PR fixes:
Fixes #4674

What this PR does / why we need it:
It obtains unused port number for TCP by unused_port method and the number has been used in UDP.
And that number may be already used by UDP sockets.

This patch will obtain and use unused ports appropriately for each protocol.

Docs Changes:

Release Note:

It obtains unused port number for TCP by unused_port method and the number has been used in UDP.
And that number may be already used by UDP sockets.
This patch will obtain and use unused ports appropriately for each protocol.

Signed-off-by: Watson <[email protected]>
@Watson1978 Watson1978 requested a review from daipom October 20, 2024 08:32
@ashie ashie merged commit d1a58fd into fluent:master Oct 21, 2024
@ashie
Copy link
Member

ashie commented Oct 21, 2024

Thanks!

@Watson1978 Watson1978 deleted the test-bind branch October 21, 2024 23:34
@kenhys kenhys mentioned this pull request Nov 28, 2024
@daipom daipom added the backport to v1.16 We will backport this fix to the LTS branch label Nov 29, 2024
@daipom daipom added the CI Test/CI issues label Jan 28, 2025
@daipom daipom added this to the v1.18.0 milestone Jan 28, 2025
kenhys pushed a commit that referenced this pull request Jan 28, 2025
It obtains unused port number for TCP by unused_port method and the number has been used in UDP.
And that number may be already used by UDP sockets.
This patch will obtain and use unused ports appropriately for each protocol.

See #4675

Signed-off-by: Watson <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
daipom pushed a commit that referenced this pull request Jan 29, 2025
**Which issue(s) this PR fixes**: 

Fixes #4674

**What this PR does / why we need it**: 

It obtains unused port number for TCP by unused_port method and the
number has been used in UDP.
And that number may be already used by UDP sockets.

This patch will obtain and use unused ports appropriately for each
protocol.

Backported from #4675

**Docs Changes**:

**Release Note**:

Signed-off-by: Watson <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
Co-authored-by: Watson <[email protected]>
@kenhys kenhys added the backported "backport to LTS" is done label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport to v1.16 We will backport this fix to the LTS branch backported "backport to LTS" is done CI Test/CI issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Fails with "Errno::EACCES: Permission denied - bind(2)" on Windows

4 participants