ci: filter_parser: reorganize tests for abnormal cases #4638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ruby 2.7 tests fail because Ruby 2.7 does not support |
daipom
force-pushed
the
filter_parser-reorganize-tests-for-abnormal-cases
branch
2 times, most recently
from
9b88e43 to
203f416
Compare
Contributor
Author
|
@kenhys Could you please review this? |
kenhys
requested changes
Sep 25, 2024
Contributor
kenhys
left a comment
kenhys
left a comment
There was a problem hiding this comment.
please split into meaningful commits making it easy to review.
daipom
force-pushed
the
filter_parser-reorganize-tests-for-abnormal-cases
branch
from
203f416 to
e5b3b20
Compare
Contributor
Author
|
Rebased to the latest master. |
Signed-off-by: Daijiro Fukuda <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
force-pushed
the
filter_parser-reorganize-tests-for-abnormal-cases
branch
from
e5b3b20 to
788417d
Compare
daipom
changed the title
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None.
What this PR does / why we need it:
Adds and reorganizes tests of
filter_parserfor abnormal cases.The following PR will significantly change the implementation of
filter_parser.However, currently, there aren't enough tests for abnormal cases.
This condition makes it difficult to safely make such a large change.
This PR solves the problem.
Docs Changes:
Not needed.
Release Note:
Same as the title.
(Or not needed because this changes only the test codes.)