Skip to content

Conversation

@kenhys
Copy link
Contributor

@kenhys kenhys commented Aug 6, 2024

Which issue(s) this PR fixes:

Fixes N/A

It is related token permission topic
https://scorecard.dev/viewer/?uri=github.com/fluent/fluentd

What this PR does / why we need it:

By default, it is enough to give read permission.
For stale actions, it require manipulate issues,
so write permission is given explicitly.

Docs Changes:

N/A

Release Note:

N/A

kenhys and others added 2 commits August 7, 2024 10:24
By default, it is enough to give read permission.
For stale actions, it require manipulate issues,
so write permission is given explicitly.

Signed-off-by: Kentaro Hayashi <[email protected]>
Co-authored-by: Takuro Ashie <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys force-pushed the fix-ci-permission branch from 2caa6b9 to 3341478 Compare August 7, 2024 01:27
@ashie ashie merged commit 5b9b1f2 into fluent:master Aug 7, 2024
@kenhys kenhys deleted the fix-ci-permission branch August 7, 2024 01:55
@daipom daipom added this to the v1.17.1 milestone Aug 15, 2024
@daipom daipom added the backport to v1.16 We will backport this fix to the LTS branch label May 14, 2025
daipom pushed a commit that referenced this pull request May 14, 2025
**Which issue(s) this PR fixes**:

Fixes N/A

It is related token permission topic
https://scorecard.dev/viewer/?uri=github.com/fluent/fluentd

**What this PR does / why we need it**:

By default, it is enough to give read permission.
For stale actions, it require manipulate issues,
so write permission is given explicitly.

**Docs Changes**:

N/A

**Release Note**:

N/A

Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom added the backported "backport to LTS" is done label May 14, 2025
daipom added a commit that referenced this pull request May 14, 2025
**Which issue(s) this PR fixes**:
 Backport #4581.

**What this PR does / why we need it**:

By default, it is enough to give read permission.
For stale actions, it require manipulate issues,
so write permission is given explicitly.

**Docs Changes**:

N/A

**Release Note**:

N/A

Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Kentaro Hayashi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport to v1.16 We will backport this fix to the LTS branch backported "backport to LTS" is done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants