Skip to content

Conversation

@daipom
Copy link
Contributor

@daipom daipom commented Jun 19, 2024

Which issue(s) this PR fixes:

What this PR does / why we need it:
Add option: encoding to handle non-ASCII characters.

Docs Changes:
TODO

Release Note:
Same as the title.

Need this feature to handle none-ascii characters.

Signed-off-by: Daijiro Fukuda <[email protected]>
daipom added a commit to clear-code/fluent-plugin-in_exec-extended-to-handle-non-ascii that referenced this pull request Jun 20, 2024
Signed-off-by: Daijiro Fukuda <[email protected]>

Co-authored-by: Kentaro Hayashi <[email protected]>
@daipom
Copy link
Contributor Author

daipom commented Jun 20, 2024

Thanks! Applied.

daipom added a commit to clear-code/fluent-plugin-in_exec-extended-to-handle-non-ascii that referenced this pull request Jun 21, 2024
Copy link
Member

@ashie ashie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@ashie ashie merged commit d4729ef into fluent:master Jul 7, 2024
@daipom daipom added this to the v1.17.1 milestone Aug 15, 2024
@daipom daipom deleted the in_exec-add-option-encoding branch August 20, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

in_exec: Can't handle non-ASCII characters output

3 participants