Skip to content

Conversation

@ganmacs
Copy link
Member

@ganmacs ganmacs commented May 29, 2019

Which issue(s) this PR fixes:

nothing

What this PR does / why we need it:

  • endpoint api/config checks if the path is valid.
  • return status code 404 if needed
  • match returned error message with
    code, header, body = render_json_error(500, {
    'message '=> 'Internal Server Error',
    'error' => "#{$!}",
    'backgrace'=> $!.backtrace,
    })

Docs Changes:

not needed

Release Note:
not needed

@ganmacs ganmacs requested a review from repeatedly May 29, 2019 09:00
@ganmacs ganmacs force-pushed the fix-return-value-when-not-found-path branch from 69bc182 to 4a4f439 Compare May 31, 2019 02:42
ganmacs added 2 commits May 31, 2019 17:40
To match a behavior of endpoint /api/plugins
They return a response whose status is 200...
should be fixed in next commit.

Signed-off-by: Yuta Iwama <[email protected]>
@ganmacs ganmacs force-pushed the fix-return-value-when-not-found-path branch 4 times, most recently from 76d5172 to 7ce4e11 Compare May 31, 2019 08:57
@ganmacs ganmacs force-pushed the fix-return-value-when-not-found-path branch from 7ce4e11 to 32a617a Compare May 31, 2019 08:58
Signed-off-by: Yuta Iwama <[email protected]>
@ganmacs ganmacs mentioned this pull request Jun 3, 2019
@repeatedly
Copy link
Member

patch itself looks good but I'm now considering merge timing.
This patch changes the behaviour so v1.6 is better for me.

@ganmacs
Copy link
Member Author

ganmacs commented Jun 4, 2019

This patch changes the behaviour so v1.6 is better for me.

reasonable for me 👍

@repeatedly repeatedly merged commit ee9831e into fluent:master Jun 11, 2019
@repeatedly
Copy link
Member

Thanks

@ganmacs ganmacs deleted the fix-return-value-when-not-found-path branch June 11, 2019 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants