Add recv_buffer parameter for in_udp #1787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeatedly
reviewed
Dec 13, 2017
lib/fluent/plugin/in_udp.rb
Outdated
| desc "Remove newline from the end of incoming payload" | ||
| config_param :remove_newline, :bool, default: true | ||
| desc "The max size of socket receive buffer. SO_RCVBUF" | ||
| config_param :recv_buffer, :size, default: nil |
Member
There was a problem hiding this comment.
receive_buffer_size is better.
Member
Author
There was a problem hiding this comment.
Okay. I just followed recv_timeout, but it isn't a parameter name yet.
Member
There was a problem hiding this comment.
Yeah, public name should be clear.
Member
Author
|
The test fails on CI. I'll check it. |
Member
|
From man page, returned value is different from get/set: http://man7.org/linux/man-pages/man7/socket.7.html |
mururu
force-pushed
the
udp-recv-buffer
branch
from
b210f0a to
d9f6c96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful for tuning of udp input.